From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47596) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1csQhM-0004Vg-JP for qemu-devel@nongnu.org; Mon, 27 Mar 2017 05:12:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1csQhI-0003nW-LK for qemu-devel@nongnu.org; Mon, 27 Mar 2017 05:12:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51718) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1csQhI-0003nR-DX for qemu-devel@nongnu.org; Mon, 27 Mar 2017 05:12:20 -0400 Date: Mon, 27 Mar 2017 17:12:08 +0800 From: Peter Xu Message-ID: <20170327091208.GG11497@pxdev.xzpeter.org> References: <1486456099-7345-1-git-send-email-peterx@redhat.com> <1486456099-7345-15-git-send-email-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v7 14/17] memory: add MemoryRegionIOMMUOps.replay() callback List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Liu, Yi L" Cc: "alex.williamson@redhat.com" , "Lan, Tianyu" , "Tian, Kevin" , "mst@redhat.com" , "jan.kiszka@siemens.com" , "jasowang@redhat.com" , "bd.aviv@gmail.com" , David Gibson , "qemu-devel@nongnu.org" On Mon, Mar 27, 2017 at 08:35:05AM +0000, Liu, Yi L wrote: > > -----Original Message----- > > From: Qemu-devel [mailto:qemu-devel-bounces+yi.l.liu=intel.com@nongnu.org] On > > Behalf Of Peter Xu > > Sent: Tuesday, February 7, 2017 4:28 PM > > To: qemu-devel@nongnu.org > > Cc: Lan, Tianyu ; Tian, Kevin ; > > mst@redhat.com; jan.kiszka@siemens.com; jasowang@redhat.com; > > peterx@redhat.com; alex.williamson@redhat.com; bd.aviv@gmail.com; David > > Gibson > > Subject: [Qemu-devel] [PATCH v7 14/17] memory: add > > MemoryRegionIOMMUOps.replay() callback > > > > Originally we have one memory_region_iommu_replay() function, which is the > > default behavior to replay the translations of the whole IOMMU region. However, > > on some platform like x86, we may want our own replay logic for IOMMU regions. > > This patch add one more hook for IOMMUOps for the callback, and it'll override the > > default if set. > > > > Signed-off-by: Peter Xu > > --- > > include/exec/memory.h | 2 ++ > > memory.c | 6 ++++++ > > 2 files changed, 8 insertions(+) > > > > diff --git a/include/exec/memory.h b/include/exec/memory.h index > > 0767888..30b2a74 100644 > > --- a/include/exec/memory.h > > +++ b/include/exec/memory.h > > @@ -191,6 +191,8 @@ struct MemoryRegionIOMMUOps { > > void (*notify_flag_changed)(MemoryRegion *iommu, > > IOMMUNotifierFlag old_flags, > > IOMMUNotifierFlag new_flags); > > + /* Set this up to provide customized IOMMU replay function */ > > + void (*replay)(MemoryRegion *iommu, IOMMUNotifier *notifier); > > }; > > > > typedef struct CoalescedMemoryRange CoalescedMemoryRange; diff --git > > a/memory.c b/memory.c index 7a4f2f9..9c253cc 100644 > > --- a/memory.c > > +++ b/memory.c > > @@ -1630,6 +1630,12 @@ void memory_region_iommu_replay(MemoryRegion > > *mr, IOMMUNotifier *n, > > hwaddr addr, granularity; > > IOMMUTLBEntry iotlb; > > + /* If the IOMMU has its own replay callback, override */ > > + if (mr->iommu_ops->replay) { > > + mr->iommu_ops->replay(mr, n); > > + return; > > + } > > Hi Alex, Peter, > > Will all the other vendors(e.g. PPC, s390, ARM) add their own replay callback > as well? I guess it depends on whether the original replay algorithm work well > for them? Do you have such knowledge? I guess so. At least for VT-d we had this callback since the default replay mechanism did not work well on x86 due to its extremely large memory region size. Thanks, -- peterx