From: Stefan Hajnoczi <stefanha@gmail.com>
To: "Xu, Anthony" <anthony.xu@intel.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Daniel Berrange <berrange@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Create libqemutrace.a for all trace.o
Date: Mon, 27 Mar 2017 14:24:54 +0100 [thread overview]
Message-ID: <20170327132454.GD28620@stefanha-x1.localdomain> (raw)
In-Reply-To: <4712D8F4B26E034E80552F30A67BE0B1A3D97E@ORSMSX112.amr.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 729 bytes --]
On Fri, Mar 24, 2017 at 04:28:32PM +0000, Xu, Anthony wrote:
> Create libqemutrace.a for all trace.o
> Currently all trace.o are linked into qemu-system, qemu-img,
> qemu-nbd, qemu-io etc., even the corresponding components
> are not included.
> Create a libqemutrace.a that the linker would only pull in .o
> files containing symbols that are actually referenced by the
> program.
> ./trace.o, ./qapi/trace.o and ./util/trace.o are added into
> libqemuutil.a to avoid recursive dependencies between
> libqemuutil.a and libqemutrace.a.
Why would libqemutrace.a depend on libqemuutil.a?
Tracing code shouldn't call other QEMU code. That would could create
infinite recursion when a trace event is fired.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2017-03-27 13:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 16:28 [Qemu-devel] [PATCH] Create libqemutrace.a for all trace.o Xu, Anthony
2017-03-27 13:24 ` Stefan Hajnoczi [this message]
2017-03-27 18:21 ` Xu, Anthony
2017-03-28 7:57 ` Paolo Bonzini
2017-03-28 19:00 ` Xu, Anthony
2017-04-03 11:14 ` Daniel P. Berrange
2017-04-03 14:42 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170327132454.GD28620@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=anthony.xu@intel.com \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).