From: Jeff Cody <jcody@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, jdurgin@redhat.com,
kwolf@redhat.com, mreitz@redhat.com, eblake@redhat.com
Subject: Re: [Qemu-devel] [PATCH v4 for-2.9 00/10] rbd: Clean up API and code
Date: Tue, 28 Mar 2017 08:17:27 -0400 [thread overview]
Message-ID: <20170328121727.GJ22342@localhost.localdomain> (raw)
In-Reply-To: <1490691368-32099-1-git-send-email-armbru@redhat.com>
On Tue, Mar 28, 2017 at 10:55:58AM +0200, Markus Armbruster wrote:
> I really, really want to correct a few issues in external interfaces
> before while I can. Bonus: several minor bug fixes.
>
> Thanks to Jeff Cody for testing this series.
>
> v4:
> * PATCH 01,04-06 unchanged
> * PATCH 02 commit message fixed up [Jeff]
> * PATCH 03 commit message tweak [Jeff]
> * PATCH 07 fixed to use qdict_get_try_str() [Max]
> * PATCH 08 commit message amended [Eric]
> * PATCH 09 fixed to revert the code change, too [Jeff]
> * old PATCH 10 dropped, PATCH 11 trivially rebased [Eric]
>
> v3:
> * PATCH 01-07 unchanged except for a doc tweak in PATCH 06
> * PATCH 08-10 replace PATCH 9
> * PATCH 8 becomes PATCH 11, rebased on top of 08-10, commit message
> updated, R-by dropped
>
> Markus Armbruster (10):
> rbd: Reject -blockdev server.*.{numeric,to,ipv4,ipv6}
> rbd: Fix to cleanly reject -drive without pool or image
> rbd: Don't limit length of parameter values
> rbd: Clean up after the previous commit
> rbd: Don't accept -drive driver=rbd,keyvalue-pairs=...
> rbd: Clean up runtime_opts, fix -drive to reject filename
> rbd: Clean up qemu_rbd_create()'s detour through QemuOpts
> rbd: Revert -blockdev and -drive parameter auth-supported
> rbd: Revert -blockdev parameter password-secret
> rbd: Fix bugs around -drive parameter "server"
>
> block/rbd.c | 319 ++++++++++++++-------------------------------------
> qapi-schema.json | 21 ++--
> qapi/block-core.json | 30 +----
> 3 files changed, 100 insertions(+), 270 deletions(-)
>
> --
> 2.7.4
>
Thanks,
Applied to my block branch:
git://github.com/codyprime/qemu-kvm-jtc.git block
-Jeff
prev parent reply other threads:[~2017-03-28 12:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 8:55 [Qemu-devel] [PATCH v4 for-2.9 00/10] rbd: Clean up API and code Markus Armbruster
2017-03-28 8:55 ` [Qemu-devel] [PATCH v4 for-2.9 01/10] rbd: Reject -blockdev server.*.{numeric, to, ipv4, ipv6} Markus Armbruster
2017-03-28 8:56 ` [Qemu-devel] [PATCH v4 for-2.9 02/10] rbd: Fix to cleanly reject -drive without pool or image Markus Armbruster
2017-03-28 8:56 ` [Qemu-devel] [PATCH v4 for-2.9 03/10] rbd: Don't limit length of parameter values Markus Armbruster
2017-03-28 8:56 ` [Qemu-devel] [PATCH v4 for-2.9 04/10] rbd: Clean up after the previous commit Markus Armbruster
2017-03-28 8:56 ` [Qemu-devel] [PATCH v4 for-2.9 05/10] rbd: Don't accept -drive driver=rbd, keyvalue-pairs= Markus Armbruster
2017-03-28 8:56 ` [Qemu-devel] [PATCH v4 for-2.9 06/10] rbd: Clean up runtime_opts, fix -drive to reject filename Markus Armbruster
2017-03-28 8:56 ` [Qemu-devel] [PATCH v4 for-2.9 07/10] rbd: Clean up qemu_rbd_create()'s detour through QemuOpts Markus Armbruster
2017-03-28 12:12 ` Jeff Cody
2017-03-28 8:56 ` [Qemu-devel] [PATCH v4 for-2.9 08/10] rbd: Revert -blockdev and -drive parameter auth-supported Markus Armbruster
2017-03-28 8:56 ` [Qemu-devel] [PATCH v4 for-2.9 09/10] rbd: Revert -blockdev parameter password-secret Markus Armbruster
2017-03-28 8:56 ` [Qemu-devel] [PATCH v4 for-2.9 10/10] rbd: Fix bugs around -drive parameter "server" Markus Armbruster
2017-03-28 12:13 ` Jeff Cody
2017-03-28 12:17 ` Jeff Cody [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170328121727.GJ22342@localhost.localdomain \
--to=jcody@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=jdurgin@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).