From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50427) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ctGr3-0002Iv-Di for qemu-devel@nongnu.org; Wed, 29 Mar 2017 12:53:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ctGqy-0000sS-8T for qemu-devel@nongnu.org; Wed, 29 Mar 2017 12:53:53 -0400 Received: from mail-lf0-x241.google.com ([2a00:1450:4010:c07::241]:35291) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ctGqy-0000qE-0y for qemu-devel@nongnu.org; Wed, 29 Mar 2017 12:53:48 -0400 Received: by mail-lf0-x241.google.com with SMTP id v2so2249724lfi.2 for ; Wed, 29 Mar 2017 09:53:47 -0700 (PDT) From: Iwona Kotlarska Date: Wed, 29 Mar 2017 18:52:51 +0200 Message-Id: <20170329165251.28740-1-iwona260909@gmail.com> Subject: [Qemu-devel] [PATCH] hmp: fix "info cpu" segfault List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, marcel@redhat.com, pbonzini@redhat.com, rth@twiddle.net, ehabkost@redhat.com, Iwona Kotlarska Running "dump-guest-memory /dev/null 0 8192" results in segfault. Fix by checking if we have CPU. Signed-off-by: Iwona Kotlarska --- target/i386/arch_dump.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/target/i386/arch_dump.c b/target/i386/arch_dump.c index 5a2e4be5d0..45cda6afb1 100644 --- a/target/i386/arch_dump.c +++ b/target/i386/arch_dump.c @@ -390,9 +390,10 @@ int cpu_get_dump_info(ArchDumpInfo *info, GuestPhysBlock *block; #ifdef TARGET_X86_64 - X86CPU *first_x86_cpu = X86_CPU(first_cpu); - - lma = !!(first_x86_cpu->env.hflags & HF_LMA_MASK); + X86CPU *first_x86_cpu = NULL; + first_x86_cpu = X86_CPU(first_cpu); + if (first_cpu != NULL) + lma = !!(first_x86_cpu->env.hflags & HF_LMA_MASK); #endif if (lma) { -- 2.12.0