[Qemu-devel] [PULL 0/1] hmp queue

[Qemu-devel] [PULL 0/1] hmp queue

[Dr. David Alan Gilbert (git)]

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

The following changes since commit 05a6f451eb0e3224a8e6d98089379f20ec06c787:

  Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2017-03-30-tag' into staging (2017-03-31 11:09:51 +0100)

are available in the git repository at:

  git://github.com/dagrh/qemu.git tags/pull-hmp-20170331

for you to fetch changes up to fd5d23babf9838c1b099a9e8020e778aac0ebb4d:

  hmp: fix "dump-quest-memory" segfault (2017-03-31 11:53:42 +0100)

----------------------------------------------------------------
HMP pull (one bugfix)

----------------------------------------------------------------
Iwona Kotlarska (1):
      hmp: fix "dump-quest-memory" segfault

 target/i386/arch_dump.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

[Qemu-devel] [PULL 1/1] hmp: fix "dump-quest-memory" segfault

[Dr. David Alan Gilbert (git)]

From: Iwona Kotlarska <iwona260909@gmail.com>

Running QEMU with "qemu-system-x86_64 -M none -nographic -m 256" and executing
"dump-guest-memory /dev/null 0 8192" results in segfault.
Fix by checking if we have CPU.

Signed-off-by: Iwona Kotlarska <iwona260909@gmail.com>
Message-Id: <20170330050924.22134-1-iwona260909@gmail.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
   Fixed up title
---
 target/i386/arch_dump.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/target/i386/arch_dump.c b/target/i386/arch_dump.c
index 5a2e4be..fe0aa36 100644
--- a/target/i386/arch_dump.c
+++ b/target/i386/arch_dump.c
@@ -391,8 +391,7 @@ int cpu_get_dump_info(ArchDumpInfo *info,
 
 #ifdef TARGET_X86_64
     X86CPU *first_x86_cpu = X86_CPU(first_cpu);
-
-    lma = !!(first_x86_cpu->env.hflags & HF_LMA_MASK);
+    lma = first_cpu && (first_x86_cpu->env.hflags & HF_LMA_MASK);
 #endif
 
     if (lma) {
-- 
2.9.3

Re: [Qemu-devel] [PULL 0/1] hmp queue

[Peter Maydell]

On 31 March 2017 at 12:02, Dr. David Alan Gilbert (git)
<dgilbert@redhat.com> wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> The following changes since commit 05a6f451eb0e3224a8e6d98089379f20ec06c787:
>
>   Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2017-03-30-tag' into staging (2017-03-31 11:09:51 +0100)
>
> are available in the git repository at:
>
>   git://github.com/dagrh/qemu.git tags/pull-hmp-20170331
>
> for you to fetch changes up to fd5d23babf9838c1b099a9e8020e778aac0ebb4d:
>
>   hmp: fix "dump-quest-memory" segfault (2017-03-31 11:53:42 +0100)
>
> ----------------------------------------------------------------
> HMP pull (one bugfix)
>
> ----------------------------------------------------------------

Applied, thanks.

-- PMM