From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33401) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ctxWY-0002i4-4d for qemu-devel@nongnu.org; Fri, 31 Mar 2017 10:27:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ctxWV-0008Vx-GD for qemu-devel@nongnu.org; Fri, 31 Mar 2017 10:27:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51451) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ctxWV-0008VU-Ax for qemu-devel@nongnu.org; Fri, 31 Mar 2017 10:27:31 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 216919F720 for ; Fri, 31 Mar 2017 14:27:30 +0000 (UTC) Date: Fri, 31 Mar 2017 15:27:24 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20170331142723.GI4514@work-vm> References: <20170323204544.12015-1-quintela@redhat.com> <20170323204544.12015-51-quintela@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170323204544.12015-51-quintela@redhat.com> Subject: Re: [Qemu-devel] [PATCH 50/51] ram: Use RAMBitmap type for coherence List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org * Juan Quintela (quintela@redhat.com) wrote: > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > migration/ram.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/migration/ram.c b/migration/ram.c > index 1be9a6b..4d62788 100644 > --- a/migration/ram.c > +++ b/migration/ram.c > @@ -1449,7 +1449,7 @@ void free_xbzrle_decoded_buf(void) > xbzrle_decoded_buf = NULL; > } > > -static void migration_bitmap_free(struct RAMBitmap *bmap) > +static void migration_bitmap_free(RAMBitmap *bmap) > { > g_free(bmap->bmap); > g_free(bmap->unsentmap); > @@ -1463,7 +1463,7 @@ static void ram_migration_cleanup(void *opaque) > /* caller have hold iothread lock or is in a bh, so there is > * no writing race against this migration_bitmap > */ > - struct RAMBitmap *bitmap = rs->ram_bitmap; > + RAMBitmap *bitmap = rs->ram_bitmap; > atomic_rcu_set(&rs->ram_bitmap, NULL); > if (bitmap) { > memory_global_dirty_log_stop(); > @@ -1502,8 +1502,8 @@ void migration_bitmap_extend(ram_addr_t old, ram_addr_t new) > * no writing race against this migration_bitmap > */ > if (rs->ram_bitmap) { > - struct RAMBitmap *old_bitmap = rs->ram_bitmap, *bitmap; > - bitmap = g_new(struct RAMBitmap, 1); > + RAMBitmap *old_bitmap = rs->ram_bitmap, *bitmap; > + bitmap = g_new(RAMBitmap, 1); > bitmap->bmap = bitmap_new(new); > > /* prevent migration_bitmap content from being set bit > @@ -1993,7 +1993,7 @@ static int ram_state_init(RAMState *rs) > rcu_read_lock(); > ram_state_reset(rs); > > - rs->ram_bitmap = g_new0(struct RAMBitmap, 1); > + rs->ram_bitmap = g_new0(RAMBitmap, 1); > /* Skip setting bitmap if there is no RAM */ > if (ram_bytes_total()) { > ram_bitmap_pages = last_ram_page(); > -- > 2.9.3 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK