From: Jeff Cody <jcody@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH for-2.9 0/2] curl: Extend and fix blockdev-add schema
Date: Fri, 31 Mar 2017 15:00:03 -0400 [thread overview]
Message-ID: <20170331190003.GH1135@localhost.localdomain> (raw)
In-Reply-To: <20170331120431.1767-1-mreitz@redhat.com>
On Fri, Mar 31, 2017 at 02:04:29PM +0200, Max Reitz wrote:
> Yes, it's yet another episode in our popular
> get-blockdev-add-ready-for-2.9 drama!
>
> Right now, the schema for the curl block driver is seriously lacking.
> This series improves things at least a bit.
>
> To improve things seriously, we might want to structure the URL instead
> of it being just a plain string, and we might want to split the cookie
> string into a list of dicts or something similar. However, strictly
> speaking our curl block driver is *not* an (ht|f)tps? block driver but
> just a curl driver. All it does is pass some options to libcurl and then
> send and receive data from it. (We really should have just named it
> "curl" from the start.)
>
> Therefore, it probably is for the best to leave these options rather
> opaque and let libcurl do the interpretation.
>
>
> Max Reitz (2):
> qapi/curl: Extend and fix blockdev-add schema
> block/curl: Check protocol prefix
>
> qapi/block-core.json | 103 ++++++++++++++++++++++++++++++++++++++++++++++-----
> block/curl.c | 10 +++++
> 2 files changed, 104 insertions(+), 9 deletions(-)
>
> --
> 2.12.1
>
>
Thanks,
Applied to my block branch:
git://github.com/codyprime/qemu-kvm-jtc.git block
-Jeff
prev parent reply other threads:[~2017-03-31 19:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 12:04 [Qemu-devel] [PATCH for-2.9 0/2] curl: Extend and fix blockdev-add schema Max Reitz
2017-03-31 12:04 ` [Qemu-devel] [PATCH for-2.9 1/2] qapi/curl: " Max Reitz
2017-03-31 18:57 ` [Qemu-devel] [Qemu-block] " Jeff Cody
2017-03-31 19:27 ` Jeff Cody
2017-03-31 19:27 ` [Qemu-devel] " Eric Blake
2017-03-31 12:04 ` [Qemu-devel] [PATCH for-2.9 2/2] block/curl: Check protocol prefix Max Reitz
2017-03-31 13:52 ` Philippe Mathieu-Daudé
2017-03-31 18:58 ` [Qemu-devel] [Qemu-block] " Jeff Cody
2017-03-31 19:14 ` [Qemu-devel] " Eric Blake
2017-03-31 19:30 ` Eric Blake
2017-03-31 20:50 ` Max Reitz
2017-03-31 19:00 ` Jeff Cody [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170331190003.GH1135@localhost.localdomain \
--to=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).