From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44902) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu1pE-00008O-NV for qemu-devel@nongnu.org; Fri, 31 Mar 2017 15:03:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cu1pB-0003Ra-K3 for qemu-devel@nongnu.org; Fri, 31 Mar 2017 15:03:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57212) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cu1pB-0003Qb-BU for qemu-devel@nongnu.org; Fri, 31 Mar 2017 15:03:05 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4BEDE61BB0 for ; Fri, 31 Mar 2017 19:03:04 +0000 (UTC) Date: Fri, 31 Mar 2017 20:02:58 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20170331190258.GH2408@work-vm> References: <1490599288-11751-1-git-send-email-peterx@redhat.com> <1490599288-11751-5-git-send-email-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1490599288-11751-5-git-send-email-peterx@redhat.com> Subject: Re: [Qemu-devel] [PATCH 4/5] hmp: info migrate_parameters format tunes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: qemu-devel@nongnu.org, Juan Quintela * Peter Xu (peterx@redhat.com) wrote: > Do the same (one per line) to the parameter list. > > CC: "Dr. David Alan Gilbert" > Signed-off-by: Peter Xu Reviewed-by: Dr. David Alan Gilbert > --- > hmp.c | 22 ++++++++++------------ > 1 file changed, 10 insertions(+), 12 deletions(-) > > diff --git a/hmp.c b/hmp.c > index 95eef8c..b33e39e 100644 > --- a/hmp.c > +++ b/hmp.c > @@ -282,46 +282,44 @@ void hmp_info_migrate_parameters(Monitor *mon, const QDict *qdict) > params = qmp_query_migrate_parameters(NULL); > > if (params) { > - monitor_printf(mon, "parameters:"); > assert(params->has_compress_level); > - monitor_printf(mon, " %s: %" PRId64, > + monitor_printf(mon, "%s: %" PRId64 "\n", > MigrationParameter_lookup[MIGRATION_PARAMETER_COMPRESS_LEVEL], > params->compress_level); > assert(params->has_compress_threads); > - monitor_printf(mon, " %s: %" PRId64, > + monitor_printf(mon, "%s: %" PRId64 "\n", > MigrationParameter_lookup[MIGRATION_PARAMETER_COMPRESS_THREADS], > params->compress_threads); > assert(params->has_decompress_threads); > - monitor_printf(mon, " %s: %" PRId64, > + monitor_printf(mon, "%s: %" PRId64 "\n", > MigrationParameter_lookup[MIGRATION_PARAMETER_DECOMPRESS_THREADS], > params->decompress_threads); > assert(params->has_cpu_throttle_initial); > - monitor_printf(mon, " %s: %" PRId64, > + monitor_printf(mon, "%s: %" PRId64 "\n", > MigrationParameter_lookup[MIGRATION_PARAMETER_CPU_THROTTLE_INITIAL], > params->cpu_throttle_initial); > assert(params->has_cpu_throttle_increment); > - monitor_printf(mon, " %s: %" PRId64, > + monitor_printf(mon, "%s: %" PRId64 "\n", > MigrationParameter_lookup[MIGRATION_PARAMETER_CPU_THROTTLE_INCREMENT], > params->cpu_throttle_increment); > - monitor_printf(mon, " %s: '%s'", > + monitor_printf(mon, "%s: '%s'\n", > MigrationParameter_lookup[MIGRATION_PARAMETER_TLS_CREDS], > params->has_tls_creds ? params->tls_creds : ""); > - monitor_printf(mon, " %s: '%s'", > + monitor_printf(mon, "%s: '%s'\n", > MigrationParameter_lookup[MIGRATION_PARAMETER_TLS_HOSTNAME], > params->has_tls_hostname ? params->tls_hostname : ""); > assert(params->has_max_bandwidth); > - monitor_printf(mon, " %s: %" PRId64 " bytes/second", > + monitor_printf(mon, "%s: %" PRId64 " bytes/second\n", > MigrationParameter_lookup[MIGRATION_PARAMETER_MAX_BANDWIDTH], > params->max_bandwidth); > assert(params->has_downtime_limit); > - monitor_printf(mon, " %s: %" PRId64 " milliseconds", > + monitor_printf(mon, "%s: %" PRId64 " milliseconds\n", > MigrationParameter_lookup[MIGRATION_PARAMETER_DOWNTIME_LIMIT], > params->downtime_limit); > assert(params->has_x_checkpoint_delay); > - monitor_printf(mon, " %s: %" PRId64, > + monitor_printf(mon, "%s: %" PRId64 "\n", > MigrationParameter_lookup[MIGRATION_PARAMETER_X_CHECKPOINT_DELAY], > params->x_checkpoint_delay); > - monitor_printf(mon, "\n"); > } > > qapi_free_MigrationParameters(params); > -- > 2.7.4 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK