From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: Laszlo Ersek <lersek@redhat.com>, Alexander Graf <agraf@suse.de>,
Marcel Apfelbaum <marcel@redhat.com>,
Thomas Huth <thuth@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Markus Armbruster <armbru@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [RFC 12/19] isabus-bridge: Remove user_creatable flag
Date: Fri, 31 Mar 2017 21:46:17 -0300 [thread overview]
Message-ID: <20170401004624.30886-13-ehabkost@redhat.com> (raw)
In-Reply-To: <20170401004624.30886-1-ehabkost@redhat.com>
isabus-bridge needs to be created by isa_bus_new(), and won't
work with -device, as it won't create the TYPE_ISA_BUS bus
itself. Remove the user_creatable flag from the device class.
Cc: Marcel Apfelbaum <marcel@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
hw/isa/isa-bus.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/hw/isa/isa-bus.c b/hw/isa/isa-bus.c
index 576dbf1763..348e0eab9d 100644
--- a/hw/isa/isa-bus.c
+++ b/hw/isa/isa-bus.c
@@ -221,11 +221,6 @@ static void isabus_bridge_class_init(ObjectClass *klass, void *data)
set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories);
dc->fw_name = "isa";
- /*
- * FIXME: Set only for compatibility on q35 machine-type.
- * Probably never meant to be user-creatable
- */
- dc->user_creatable = true;
}
static const TypeInfo isabus_bridge_info = {
--
2.11.0.259.g40922b1
next prev parent reply other threads:[~2017-04-01 0:47 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-01 0:46 [Qemu-devel] [RFC 00/19] sysbus: Don't allow -device/device_add by default Eduardo Habkost
2017-04-01 0:46 ` [Qemu-devel] [RFC 01/19] qdev: Replace cannot_instantiate_with_device_add_yet with !user_creatable Eduardo Habkost
2017-04-03 17:16 ` Alistair Francis
2017-04-01 0:46 ` [Qemu-devel] [RFC 02/19] s390: Add FIXME for unexplained user_creatable=false line Eduardo Habkost
2017-04-03 8:55 ` Cornelia Huck
2017-04-03 19:20 ` Eduardo Habkost
2017-04-04 6:46 ` Cornelia Huck
2017-04-01 0:46 ` [Qemu-devel] [RFC 03/19] sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE Eduardo Habkost
2017-04-03 19:49 ` Peter Maydell
2017-04-03 20:10 ` Eduardo Habkost
2017-04-03 20:15 ` Alexander Graf
2017-04-03 21:00 ` Eduardo Habkost
2017-04-04 6:53 ` Alexander Graf
2017-04-04 6:58 ` Thomas Huth
2017-04-04 7:02 ` Alexander Graf
2017-04-04 12:59 ` Eduardo Habkost
2017-04-04 13:06 ` Alexander Graf
2017-04-04 14:44 ` Eduardo Habkost
2017-04-04 13:05 ` Eduardo Habkost
2017-04-01 0:46 ` [Qemu-devel] [RFC 04/19] fdc: Remove user_creatable flag from sysbus-fdc & SUNW, fdtwo Eduardo Habkost
2017-04-01 0:46 ` [Qemu-devel] [RFC 05/19] pflash_cfi01: Remove user_creatable flag Eduardo Habkost
2017-04-03 12:43 ` Philippe Mathieu-Daudé
2017-04-03 15:45 ` Laszlo Ersek
2017-04-01 0:46 ` [Qemu-devel] [RFC 06/19] iommu: Remove FIXME comment about user_creatable=true Eduardo Habkost
2017-04-01 0:46 ` [Qemu-devel] [RFC 07/19] kvmclock: Remove user_creatable flag Eduardo Habkost
2017-04-01 0:46 ` [Qemu-devel] [RFC 08/19] ioapic: " Eduardo Habkost
2017-04-01 0:46 ` [Qemu-devel] [RFC 09/19] kvmvapic: " Eduardo Habkost
2017-04-01 0:46 ` [Qemu-devel] [RFC 10/19] sysbus-ahci: " Eduardo Habkost
2017-04-03 17:19 ` Alistair Francis
2017-04-01 0:46 ` [Qemu-devel] [RFC 11/19] allwinner-ahci: " Eduardo Habkost
2017-04-01 0:46 ` Eduardo Habkost [this message]
2017-04-01 0:46 ` [Qemu-devel] [RFC 13/19] unimplemented-device: " Eduardo Habkost
2017-04-03 12:44 ` Philippe Mathieu-Daudé
2017-04-03 12:57 ` Peter Maydell
2017-04-03 13:34 ` Eduardo Habkost
2017-04-03 13:38 ` Peter Maydell
2017-04-03 13:54 ` Eduardo Habkost
2017-04-03 14:08 ` Peter Maydell
2017-04-03 18:30 ` Eduardo Habkost
2017-04-03 19:42 ` Peter Maydell
2017-04-03 20:05 ` Eduardo Habkost
2017-04-04 7:05 ` Thomas Huth
2017-04-04 7:12 ` Alexander Graf
2017-04-04 13:12 ` Eduardo Habkost
2017-04-01 0:46 ` [Qemu-devel] [RFC 14/19] fw_cfg: " Eduardo Habkost
2017-04-03 15:46 ` Laszlo Ersek
2017-04-01 0:46 ` [Qemu-devel] [RFC 15/19] esp: " Eduardo Habkost
2017-04-01 0:46 ` [Qemu-devel] [RFC 16/19] generic-sdhci: " Eduardo Habkost
2017-04-03 17:20 ` Alistair Francis
2017-04-01 0:46 ` [Qemu-devel] [RFC 17/19] hpet: " Eduardo Habkost
2017-04-01 0:46 ` [Qemu-devel] [RFC 18/19] sysbus-ohci: " Eduardo Habkost
2017-04-01 0:46 ` [Qemu-devel] [RFC 19/19] virtio-mmio: " Eduardo Habkost
2017-04-03 15:50 ` Laszlo Ersek
2017-04-04 19:35 ` Eduardo Habkost
2017-04-05 8:30 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170401004624.30886-13-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=agraf@suse.de \
--cc=armbru@redhat.com \
--cc=lersek@redhat.com \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).