From: David Gibson <david@gibson.dropbear.id.au>
To: Danil Antonov <g.danil.anto@gmail.com>
Cc: qemu-devel@nongnu.org, agraf@suse.de
Subject: Re: [Qemu-devel] [PATCH 09/43] ppc: made printf always compile in debug output
Date: Sun, 2 Apr 2017 16:44:17 +1000 [thread overview]
Message-ID: <20170402064417.GF16790@umbus.fritz.box> (raw)
In-Reply-To: <CA+KKJYD3duCUjOuYH-fsH1HTUkGLugF6-YX0L1+Kdd9z-sVYqw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 994 bytes --]
On Sat, Apr 01, 2017 at 04:44:36PM +0300, Danil Antonov wrote:
> >From 236c82fee189c22b88313fda71816e486edab8a6 Mon Sep 17 00:00:00 2001
> From: Danil Antonov <g.danil.anto@gmail.com>
> Date: Wed, 29 Mar 2017 12:23:58 +0300
> Subject: [PATCH 09/43] ppc: made printf always compile in debug output
>
> Wrapped printf calls inside debug macros (DPRINTF) in `if` statement.
> This will ensure that printf function will always compile even if debug
> output is turned off and, in turn, will prevent bitrot of the format
> strings.
>
> Signed-off-by: Danil Antonov <g.danil.anto@gmail.com>
Hrm. Long term we really wantto change these to tracepoints anyway,
so I'm not sure how useful this is on its own. I'd apply it anyway,
except it no longer applies clear against ppc-for-2.10.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2017-04-02 6:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-01 13:44 [Qemu-devel] [PATCH 09/43] ppc: made printf always compile in debug output Danil Antonov
2017-04-02 6:44 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170402064417.GF16790@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=agraf@suse.de \
--cc=g.danil.anto@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).