From: "Alex Bennée" <alex.bennee@linaro.org>
To: dovgaluk@ispras.ru, rth@twiddle.net, pbonzini@redhat.com
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org,
mttcg@listserver.greensocs.com, fred.konrad@greensocs.com,
a.rigo@virtualopensystems.com, cota@braap.org,
bobby.prani@gmail.com, nikunj@linux.vnet.ibm.com,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: [Qemu-devel] [PATCH v2 00/12] icount and misc MTTCG fixes for 2.9-rc4
Date: Wed, 5 Apr 2017 14:24:51 +0100 [thread overview]
Message-ID: <20170405132503.32125-1-alex.bennee@linaro.org> (raw)
Hi,
Here is my current queue for icount and miscellaneous MTTCG related
fixes. The main difference from the RFC series is I have dropped the
graceful handling of backward time events in the replay log in favour
of updating the global qemu_icount more frequently. The graceful
handling is now replaced with an assertion about the arrow of time.
With these changes I was able to dispenses with additional BQL locking
which I had been applying during cpu_handle_exception.
It doesn't completely solve the problem of keeping the main-loop and
vCPU events stream in sync but it works pretty reliably in my test
case. Given the current release time-line I think this is the best
solution for now. Options for post-2.9 include either replacing the
BQL mediated sequencing with a new lock (pushing replay_lock up the
tree?) or marshalling events through a single thread which can then
keep things in order.
Aside from that other patches have had various r-b and a-b tags
applied from the original posting.
I hope to roll a pull request with these fixes by the end of the week
so we there isn't a rush for next Tuesday's rc4. Expedient comments
and reviews are therefor gratefully received ;-)
Regards,
Alex Bennée (12):
scripts/qemugdb/mtree.py: fix up mtree dump
scripts/qemu-gdb/timers.py: new helper to dump timer state
scripts/replay-dump.py: replay log dumper
target/i386/misc_helper: wrap BQL around another IRQ generator
cpus: remove icount handling from qemu_tcg_cpu_thread_fn
cpus: check cpu->running in cpu_get_icount_raw()
cpus: move icount preparation out of tcg_exec_cpu
cpus: don't credit executed instructions before they have run
cpus: introduce cpu_update_icount helper
cpu-exec: update icount after each TB_EXIT
cpus: call cpu_update_icount on read
replay: assert time only goes forward
cpu-exec.c | 14 +--
cpus.c | 98 ++++++++++++-----
include/qemu/timer.h | 1 +
include/qom/cpu.h | 1 +
replay/replay-internal.c | 4 +
replay/replay.c | 4 +
scripts/qemu-gdb.py | 3 +-
scripts/qemugdb/mtree.py | 12 +-
scripts/qemugdb/timers.py | 54 +++++++++
scripts/replay-dump.py | 272 ++++++++++++++++++++++++++++++++++++++++++++++
target/i386/misc_helper.c | 3 +
11 files changed, 426 insertions(+), 40 deletions(-)
create mode 100644 scripts/qemugdb/timers.py
create mode 100755 scripts/replay-dump.py
--
2.11.0
next reply other threads:[~2017-04-05 13:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 13:24 Alex Bennée [this message]
2017-04-05 13:24 ` [Qemu-devel] [PATCH v2 01/12] scripts/qemugdb/mtree.py: fix up mtree dump Alex Bennée
2017-04-05 13:24 ` [Qemu-devel] [PATCH v2 02/12] scripts/qemu-gdb/timers.py: new helper to dump timer state Alex Bennée
2017-04-05 13:24 ` [Qemu-devel] [PATCH v2 03/12] scripts/replay-dump.py: replay log dumper Alex Bennée
2017-04-05 13:24 ` [Qemu-devel] [PATCH v2 04/12] target/i386/misc_helper: wrap BQL around another IRQ generator Alex Bennée
2017-04-05 13:24 ` [Qemu-devel] [PATCH v2 05/12] cpus: remove icount handling from qemu_tcg_cpu_thread_fn Alex Bennée
2017-04-05 13:24 ` [Qemu-devel] [PATCH v2 06/12] cpus: check cpu->running in cpu_get_icount_raw() Alex Bennée
2017-04-05 13:24 ` [Qemu-devel] [PATCH v2 07/12] cpus: move icount preparation out of tcg_exec_cpu Alex Bennée
2017-04-05 13:24 ` [Qemu-devel] [PATCH v2 08/12] cpus: don't credit executed instructions before they have run Alex Bennée
2017-04-05 13:25 ` [Qemu-devel] [PATCH v2 09/12] cpus: introduce cpu_update_icount helper Alex Bennée
2017-04-05 14:08 ` Paolo Bonzini
2017-04-05 14:34 ` Alex Bennée
2017-04-05 15:00 ` Paolo Bonzini
2017-04-05 13:25 ` [Qemu-devel] [PATCH v2 10/12] cpu-exec: update icount after each TB_EXIT Alex Bennée
2017-04-05 13:25 ` [Qemu-devel] [PATCH v2 11/12] cpus: call cpu_update_icount on read Alex Bennée
2017-04-05 14:07 ` Paolo Bonzini
2017-04-07 11:35 ` Alex Bennée
2017-04-07 12:19 ` Paolo Bonzini
2017-04-07 13:14 ` Alex Bennée
2017-04-07 18:42 ` Richard Henderson
2017-04-05 13:25 ` [Qemu-devel] [PATCH v2 12/12] replay: assert time only goes forward Alex Bennée
2017-04-05 13:33 ` Pavel Dovgalyuk
2017-04-05 13:49 ` Paolo Bonzini
2017-04-05 14:37 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170405132503.32125-1-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=a.rigo@virtualopensystems.com \
--cc=bobby.prani@gmail.com \
--cc=cota@braap.org \
--cc=dovgaluk@ispras.ru \
--cc=fred.konrad@greensocs.com \
--cc=mttcg@listserver.greensocs.com \
--cc=nikunj@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).