From: Igor Mammedov <imammedo@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Jan Kiszka <jan.kiszka@siemens.com>,
qemu-devel@nongnu.org, "Emilio G. Cota" <cota@braap.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Pranith Kumar <bobby.prani@gmail.com>,
KONRAD Frederic <fred.konrad@greensocs.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] qemu-2.9 crashes in tcg_handle_interrupt() during winx64 boot
Date: Wed, 5 Apr 2017 18:03:36 +0200 [thread overview]
Message-ID: <20170405180336.37b20125@nial.brq.redhat.com> (raw)
In-Reply-To: <87wpaz9e9g.fsf@linaro.org>
On Wed, 05 Apr 2017 14:26:35 +0100
Alex Bennée <alex.bennee@linaro.org> wrote:
> Igor Mammedov <imammedo@redhat.com> writes:
>
> > On Fri, 31 Mar 2017 09:58:49 +0100
> > Alex Bennée <alex.bennee@linaro.org> wrote:
> >
> >> Igor Mammedov <imammedo@redhat.com> writes:
> >>
> >> > On Thu, 30 Mar 2017 16:05:58 +0100
> >> > Alex Bennée <alex.bennee@linaro.org> wrote:
> >> >
> >> >> Igor Mammedov <imammedo@redhat.com> writes:
> >> >>
> >> >> > (PS: resend due to wrong qemu-devel mail list address in original
> >> >> > email)
> >> >>
> >> >> Le *sigh* another way of x86 generating IRQs ;-)
> >> >>
> >> >> Could you test this please?
> >> >>
> >> >> target/i386/misc_helper: wrap BQL around another IRQ generator
> >> >>
> >> >> Anything that calls into HW emulation must be protected by the BQL.
> >> >>
> >> >> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> >> > it doesn't help,
> >> > it asserts in the same place anyway
> >>
> >> That's weird. If the lock was already held I could see it failing higher
> >> up but this seems to imply we are dropping a lock as we descend into
> >> hardware emulation.
> > I'm sorry,
> > when testing it I've misplaced locking into helper_read_crN(),
> > left write path untouched and went hunting for weird behavior.
> >
> > Anyway,
> > I've tested you patch again and windows guest boots fine with it.
>
> No problem - I've done the same before ;-)
It wasn't totally wasteful though,
I've learned how to do nested breakpoints in gdb
>
> Can I have a Tested-by?
sure,
Tested-by: Igor Mammedov <imammedo@redhat.com>
>
> --
> Alex Bennée
prev parent reply other threads:[~2017-04-05 16:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-30 14:46 [Qemu-devel] qemu-2.9 crashes in tcg_handle_interrupt() during winx64 boot Igor Mammedov
2017-03-30 15:05 ` Alex Bennée
2017-03-30 16:14 ` Alex Bennée
2017-03-31 8:21 ` Igor Mammedov
2017-03-31 8:58 ` Alex Bennée
2017-03-31 12:08 ` Paolo Bonzini
2017-04-05 12:51 ` Igor Mammedov
2017-04-05 13:26 ` Alex Bennée
2017-04-05 16:03 ` Igor Mammedov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170405180336.37b20125@nial.brq.redhat.com \
--to=imammedo@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=bobby.prani@gmail.com \
--cc=cota@braap.org \
--cc=fred.konrad@greensocs.com \
--cc=jan.kiszka@siemens.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).