From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60976) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cvquh-0002zf-Tb for qemu-devel@nongnu.org; Wed, 05 Apr 2017 15:48:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cvque-0008A3-TA for qemu-devel@nongnu.org; Wed, 05 Apr 2017 15:48:19 -0400 From: Eric Blake Date: Wed, 5 Apr 2017 14:47:40 -0500 Message-Id: <20170405194741.18956-13-eblake@redhat.com> In-Reply-To: <20170405194741.18956-1-eblake@redhat.com> References: <20170405194741.18956-1-eblake@redhat.com> Subject: [Qemu-devel] [PATCH v3 12/13] fdc-test: Avoid deprecated 'change' command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: armbru@redhat.com, John Snow , "open list:Floppy" Use the preferred blockdev-change-medium command instead. Admittedly, use of 'device' is also deprecated over the newer use of 'id', but the test is exploiting that the name 'floppy0' is auto-created by the board, and I could not figure out where the command line lives that would need to be tweaked to provide a non-random 'id' to this device. Signed-off-by: Eric Blake Reviewed-by: John Snow --- v3: update commit message to point out that we are still using deprecated 'device' --- tests/fdc-test.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/fdc-test.c b/tests/fdc-test.c index 738c6b4..f5ff68d 100644 --- a/tests/fdc-test.c +++ b/tests/fdc-test.c @@ -298,8 +298,9 @@ static void test_media_insert(void) /* Insert media in drive. DSKCHK should not be reset until a step pulse * is sent. */ - qmp_discard_response("{'execute':'change', 'arguments':{" - " 'device':'floppy0', 'target': %s, 'arg': 'raw' }}", + qmp_discard_response("{'execute':'blockdev-change-medium', 'arguments':{" + " 'device':'floppy0', 'filename': %s, " + "'format': 'raw' }}", test_image); dir = inb(FLOPPY_BASE + reg_dir); -- 2.9.3