Re: [Qemu-devel] [PATCH v3 03/13] s390x: Drop useless casts

[Cornelia Huck <cornelia.huck@de.ibm.com>]

On Wed,  5 Apr 2017 14:47:31 -0500
Eric Blake <eblake@redhat.com> wrote:

> An upcoming Coccinelle cleanup script wanted to reformat the casts
> present in this file - but on closer look, we don't need the casts
> at all because C automatically converts void* to any other pointer.
> 
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
>  target/s390x/cpu_models.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c
> index 1434d15..ce461cc 100644
> --- a/target/s390x/cpu_models.c
> +++ b/target/s390x/cpu_models.c
> @@ -376,12 +376,12 @@ static void cpu_model_from_info(S390CPUModel *model, const CpuModelInfo *info,
> 
>  static void qdict_add_disabled_feat(const char *name, void *opaque)
>  {
> -    qdict_put((QDict *) opaque, name, qbool_from_bool(false));
> +    qdict_put(opaque, name, qbool_from_bool(false));
>  }
> 
>  static void qdict_add_enabled_feat(const char *name, void *opaque)
>  {
> -    qdict_put((QDict *) opaque, name, qbool_from_bool(true));
> +    qdict_put(opaque, name, qbool_from_bool(true));
>  }
> 
>  /* convert S390CPUDef into a static CpuModelInfo */

Do you prefer to keep this in this series, or should we just go ahead
and apply this via s390x?

In any case,

Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>