* [Qemu-devel] [PATCH] virtio-gpu: replace PIXMAN_* by PIXMAN_BE_*
@ 2017-04-03 11:40 Laurent Vivier
2017-04-03 12:28 ` Philippe Mathieu-Daudé
2017-04-07 10:29 ` [Qemu-devel] " Gerd Hoffmann
0 siblings, 2 replies; 4+ messages in thread
From: Laurent Vivier @ 2017-04-03 11:40 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: qemu-trivial, qemu-devel, Laurent Vivier
This avoids a "#ifdef HOST_WORDS_BIGENDIAN" and this is the purpose
of PIXMAN_BE_* macros.
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
hw/display/virtio-gpu.c | 35 ++++++++---------------------------
1 file changed, 8 insertions(+), 27 deletions(-)
diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
index 9b530ab..7befcef 100644
--- a/hw/display/virtio-gpu.c
+++ b/hw/display/virtio-gpu.c
@@ -258,41 +258,22 @@ void virtio_gpu_get_display_info(VirtIOGPU *g,
static pixman_format_code_t get_pixman_format(uint32_t virtio_gpu_format)
{
switch (virtio_gpu_format) {
-#ifdef HOST_WORDS_BIGENDIAN
case VIRTIO_GPU_FORMAT_B8G8R8X8_UNORM:
- return PIXMAN_b8g8r8x8;
+ return PIXMAN_BE_b8g8r8x8;
case VIRTIO_GPU_FORMAT_B8G8R8A8_UNORM:
- return PIXMAN_b8g8r8a8;
+ return PIXMAN_BE_b8g8r8a8;
case VIRTIO_GPU_FORMAT_X8R8G8B8_UNORM:
- return PIXMAN_x8r8g8b8;
+ return PIXMAN_BE_x8r8g8b8;
case VIRTIO_GPU_FORMAT_A8R8G8B8_UNORM:
- return PIXMAN_a8r8g8b8;
+ return PIXMAN_BE_a8r8g8b8;
case VIRTIO_GPU_FORMAT_R8G8B8X8_UNORM:
- return PIXMAN_r8g8b8x8;
+ return PIXMAN_BE_r8g8b8x8;
case VIRTIO_GPU_FORMAT_R8G8B8A8_UNORM:
- return PIXMAN_r8g8b8a8;
+ return PIXMAN_BE_r8g8b8a8;
case VIRTIO_GPU_FORMAT_X8B8G8R8_UNORM:
- return PIXMAN_x8b8g8r8;
+ return PIXMAN_BE_x8b8g8r8;
case VIRTIO_GPU_FORMAT_A8B8G8R8_UNORM:
- return PIXMAN_a8b8g8r8;
-#else
- case VIRTIO_GPU_FORMAT_B8G8R8X8_UNORM:
- return PIXMAN_x8r8g8b8;
- case VIRTIO_GPU_FORMAT_B8G8R8A8_UNORM:
- return PIXMAN_a8r8g8b8;
- case VIRTIO_GPU_FORMAT_X8R8G8B8_UNORM:
- return PIXMAN_b8g8r8x8;
- case VIRTIO_GPU_FORMAT_A8R8G8B8_UNORM:
- return PIXMAN_b8g8r8a8;
- case VIRTIO_GPU_FORMAT_R8G8B8X8_UNORM:
- return PIXMAN_x8b8g8r8;
- case VIRTIO_GPU_FORMAT_R8G8B8A8_UNORM:
- return PIXMAN_a8b8g8r8;
- case VIRTIO_GPU_FORMAT_X8B8G8R8_UNORM:
- return PIXMAN_r8g8b8x8;
- case VIRTIO_GPU_FORMAT_A8B8G8R8_UNORM:
- return PIXMAN_r8g8b8a8;
-#endif
+ return PIXMAN_BE_a8b8g8r8;
default:
return 0;
}
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] virtio-gpu: replace PIXMAN_* by PIXMAN_BE_*
2017-04-03 11:40 [Qemu-devel] [PATCH] virtio-gpu: replace PIXMAN_* by PIXMAN_BE_* Laurent Vivier
@ 2017-04-03 12:28 ` Philippe Mathieu-Daudé
2017-04-06 10:43 ` [Qemu-devel] [Qemu-trivial] " Sahid Orentino Ferdjaoui
2017-04-07 10:29 ` [Qemu-devel] " Gerd Hoffmann
1 sibling, 1 reply; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2017-04-03 12:28 UTC (permalink / raw)
To: Laurent Vivier, Gerd Hoffmann; +Cc: qemu-trivial, qemu-devel
On 04/03/2017 08:40 AM, Laurent Vivier wrote:
> This avoids a "#ifdef HOST_WORDS_BIGENDIAN" and this is the purpose
> of PIXMAN_BE_* macros.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/display/virtio-gpu.c | 35 ++++++++---------------------------
> 1 file changed, 8 insertions(+), 27 deletions(-)
>
> diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
> index 9b530ab..7befcef 100644
> --- a/hw/display/virtio-gpu.c
> +++ b/hw/display/virtio-gpu.c
> @@ -258,41 +258,22 @@ void virtio_gpu_get_display_info(VirtIOGPU *g,
> static pixman_format_code_t get_pixman_format(uint32_t virtio_gpu_format)
> {
> switch (virtio_gpu_format) {
> -#ifdef HOST_WORDS_BIGENDIAN
> case VIRTIO_GPU_FORMAT_B8G8R8X8_UNORM:
> - return PIXMAN_b8g8r8x8;
> + return PIXMAN_BE_b8g8r8x8;
> case VIRTIO_GPU_FORMAT_B8G8R8A8_UNORM:
> - return PIXMAN_b8g8r8a8;
> + return PIXMAN_BE_b8g8r8a8;
> case VIRTIO_GPU_FORMAT_X8R8G8B8_UNORM:
> - return PIXMAN_x8r8g8b8;
> + return PIXMAN_BE_x8r8g8b8;
> case VIRTIO_GPU_FORMAT_A8R8G8B8_UNORM:
> - return PIXMAN_a8r8g8b8;
> + return PIXMAN_BE_a8r8g8b8;
> case VIRTIO_GPU_FORMAT_R8G8B8X8_UNORM:
> - return PIXMAN_r8g8b8x8;
> + return PIXMAN_BE_r8g8b8x8;
> case VIRTIO_GPU_FORMAT_R8G8B8A8_UNORM:
> - return PIXMAN_r8g8b8a8;
> + return PIXMAN_BE_r8g8b8a8;
> case VIRTIO_GPU_FORMAT_X8B8G8R8_UNORM:
> - return PIXMAN_x8b8g8r8;
> + return PIXMAN_BE_x8b8g8r8;
> case VIRTIO_GPU_FORMAT_A8B8G8R8_UNORM:
> - return PIXMAN_a8b8g8r8;
> -#else
> - case VIRTIO_GPU_FORMAT_B8G8R8X8_UNORM:
> - return PIXMAN_x8r8g8b8;
> - case VIRTIO_GPU_FORMAT_B8G8R8A8_UNORM:
> - return PIXMAN_a8r8g8b8;
> - case VIRTIO_GPU_FORMAT_X8R8G8B8_UNORM:
> - return PIXMAN_b8g8r8x8;
> - case VIRTIO_GPU_FORMAT_A8R8G8B8_UNORM:
> - return PIXMAN_b8g8r8a8;
> - case VIRTIO_GPU_FORMAT_R8G8B8X8_UNORM:
> - return PIXMAN_x8b8g8r8;
> - case VIRTIO_GPU_FORMAT_R8G8B8A8_UNORM:
> - return PIXMAN_a8b8g8r8;
> - case VIRTIO_GPU_FORMAT_X8B8G8R8_UNORM:
> - return PIXMAN_r8g8b8x8;
> - case VIRTIO_GPU_FORMAT_A8B8G8R8_UNORM:
> - return PIXMAN_r8g8b8a8;
> -#endif
> + return PIXMAN_BE_a8b8g8r8;
> default:
> return 0;
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] virtio-gpu: replace PIXMAN_* by PIXMAN_BE_*
2017-04-03 12:28 ` Philippe Mathieu-Daudé
@ 2017-04-06 10:43 ` Sahid Orentino Ferdjaoui
0 siblings, 0 replies; 4+ messages in thread
From: Sahid Orentino Ferdjaoui @ 2017-04-06 10:43 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Laurent Vivier, Gerd Hoffmann, qemu-trivial, qemu-devel
On Mon, Apr 03, 2017 at 09:28:02AM -0300, Philippe Mathieu-Daudé wrote:
> On 04/03/2017 08:40 AM, Laurent Vivier wrote:
> > This avoids a "#ifdef HOST_WORDS_BIGENDIAN" and this is the purpose
> > of PIXMAN_BE_* macros.
> >
> > Signed-off-by: Laurent Vivier <lvivier@redhat.com>
>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
Reviewed-by: Sahid Orentino Ferdjaoui <sahid.ferdjaoui@redhat.com>
>
> > ---
> > hw/display/virtio-gpu.c | 35 ++++++++---------------------------
> > 1 file changed, 8 insertions(+), 27 deletions(-)
> >
> > diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
> > index 9b530ab..7befcef 100644
> > --- a/hw/display/virtio-gpu.c
> > +++ b/hw/display/virtio-gpu.c
> > @@ -258,41 +258,22 @@ void virtio_gpu_get_display_info(VirtIOGPU *g,
> > static pixman_format_code_t get_pixman_format(uint32_t virtio_gpu_format)
> > {
> > switch (virtio_gpu_format) {
> > -#ifdef HOST_WORDS_BIGENDIAN
> > case VIRTIO_GPU_FORMAT_B8G8R8X8_UNORM:
> > - return PIXMAN_b8g8r8x8;
> > + return PIXMAN_BE_b8g8r8x8;
> > case VIRTIO_GPU_FORMAT_B8G8R8A8_UNORM:
> > - return PIXMAN_b8g8r8a8;
> > + return PIXMAN_BE_b8g8r8a8;
> > case VIRTIO_GPU_FORMAT_X8R8G8B8_UNORM:
> > - return PIXMAN_x8r8g8b8;
> > + return PIXMAN_BE_x8r8g8b8;
> > case VIRTIO_GPU_FORMAT_A8R8G8B8_UNORM:
> > - return PIXMAN_a8r8g8b8;
> > + return PIXMAN_BE_a8r8g8b8;
> > case VIRTIO_GPU_FORMAT_R8G8B8X8_UNORM:
> > - return PIXMAN_r8g8b8x8;
> > + return PIXMAN_BE_r8g8b8x8;
> > case VIRTIO_GPU_FORMAT_R8G8B8A8_UNORM:
> > - return PIXMAN_r8g8b8a8;
> > + return PIXMAN_BE_r8g8b8a8;
> > case VIRTIO_GPU_FORMAT_X8B8G8R8_UNORM:
> > - return PIXMAN_x8b8g8r8;
> > + return PIXMAN_BE_x8b8g8r8;
> > case VIRTIO_GPU_FORMAT_A8B8G8R8_UNORM:
> > - return PIXMAN_a8b8g8r8;
> > -#else
> > - case VIRTIO_GPU_FORMAT_B8G8R8X8_UNORM:
> > - return PIXMAN_x8r8g8b8;
> > - case VIRTIO_GPU_FORMAT_B8G8R8A8_UNORM:
> > - return PIXMAN_a8r8g8b8;
> > - case VIRTIO_GPU_FORMAT_X8R8G8B8_UNORM:
> > - return PIXMAN_b8g8r8x8;
> > - case VIRTIO_GPU_FORMAT_A8R8G8B8_UNORM:
> > - return PIXMAN_b8g8r8a8;
> > - case VIRTIO_GPU_FORMAT_R8G8B8X8_UNORM:
> > - return PIXMAN_x8b8g8r8;
> > - case VIRTIO_GPU_FORMAT_R8G8B8A8_UNORM:
> > - return PIXMAN_a8b8g8r8;
> > - case VIRTIO_GPU_FORMAT_X8B8G8R8_UNORM:
> > - return PIXMAN_r8g8b8x8;
> > - case VIRTIO_GPU_FORMAT_A8B8G8R8_UNORM:
> > - return PIXMAN_r8g8b8a8;
> > -#endif
> > + return PIXMAN_BE_a8b8g8r8;
> > default:
> > return 0;
> > }
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] virtio-gpu: replace PIXMAN_* by PIXMAN_BE_*
2017-04-03 11:40 [Qemu-devel] [PATCH] virtio-gpu: replace PIXMAN_* by PIXMAN_BE_* Laurent Vivier
2017-04-03 12:28 ` Philippe Mathieu-Daudé
@ 2017-04-07 10:29 ` Gerd Hoffmann
1 sibling, 0 replies; 4+ messages in thread
From: Gerd Hoffmann @ 2017-04-07 10:29 UTC (permalink / raw)
To: Laurent Vivier; +Cc: qemu-trivial, qemu-devel
On Mo, 2017-04-03 at 13:40 +0200, Laurent Vivier wrote:
> This avoids a "#ifdef HOST_WORDS_BIGENDIAN" and this is the purpose
> of PIXMAN_BE_* macros.
Added to vga queue (for 2.10).
thanks,
Gerd
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-04-07 10:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-03 11:40 [Qemu-devel] [PATCH] virtio-gpu: replace PIXMAN_* by PIXMAN_BE_* Laurent Vivier
2017-04-03 12:28 ` Philippe Mathieu-Daudé
2017-04-06 10:43 ` [Qemu-devel] [Qemu-trivial] " Sahid Orentino Ferdjaoui
2017-04-07 10:29 ` [Qemu-devel] " Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).