qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, borntraeger@de.ibm.com,
	Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>,
	agraf@suse.de
Subject: Re: [Qemu-devel] [PATCH for-2.10 05/10] s390x/css: provide introspection for virtual subchannel and device busid
Date: Thu, 6 Apr 2017 15:16:10 +0200	[thread overview]
Message-ID: <20170406151610.0f8c867e.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <5e9b4ef5-f737-bc26-433d-f111e44e294a@redhat.com>

On Thu, 6 Apr 2017 14:19:10 +0200
Thomas Huth <thuth@redhat.com> wrote:

> On 06.04.2017 13:16, Cornelia Huck wrote:

> > +out_err:
> > +    error_propagate(errp, err);
> > +    css_subch_assign(sch->cssid, sch->ssid, sch->schid, sch->devno, NULL);
> > +    ccw_dev->sch = NULL;
> > +    g_free(sch);
> > +    return;
> >  }
> 
> Cosmetic nit: Remove the unnecessary "return;" statement right before
> the closing curly bracket.

Yup, will merge in.

  reply	other threads:[~2017-04-06 13:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-06 11:16 [Qemu-devel] [PATCH for-2.10 00/10] s390x queue for 2.10 Cornelia Huck
2017-04-06 11:16 ` [Qemu-devel] [PATCH for-2.10 01/10] s390x: introduce 2.10 compat machine Cornelia Huck
2017-04-06 11:16 ` [Qemu-devel] [PATCH for-2.10 02/10] s390x/kvm: make printf always compile in debug output Cornelia Huck
2017-04-06 11:16 ` [Qemu-devel] [PATCH for-2.10 03/10] s390x/pci: " Cornelia Huck
2017-04-06 12:15   ` Thomas Huth
2017-04-06 13:07     ` Cornelia Huck
2017-04-06 11:16 ` [Qemu-devel] [PATCH for-2.10 04/10] s390x/css: introduce read-only property type for device ids Cornelia Huck
2017-04-06 11:16 ` [Qemu-devel] [PATCH for-2.10 05/10] s390x/css: provide introspection for virtual subchannel and device busid Cornelia Huck
2017-04-06 12:19   ` Thomas Huth
2017-04-06 13:16     ` Cornelia Huck [this message]
2017-04-06 11:16 ` [Qemu-devel] [PATCH for-2.10 06/10] s390x/css: consolidate the devno property for ccw devices Cornelia Huck
2017-04-06 11:16 ` [Qemu-devel] [PATCH for-2.10 07/10] s390x: use enum for adapter type and standardize its naming Cornelia Huck
2017-04-06 11:16 ` [Qemu-devel] [PATCH for-2.10 08/10] s390x: initialize flic before I/O subsystems Cornelia Huck
2017-04-06 11:16 ` [Qemu-devel] [PATCH for-2.10 09/10] s390x/flic: cache flic in s390_get_flic Cornelia Huck
2017-04-06 11:16 ` [Qemu-devel] [PATCH for-2.10 10/10] s390x: register I/O adapters per ISC during init Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170406151610.0f8c867e.cornelia.huck@de.ibm.com \
    --to=cornelia.huck@de.ibm.com \
    --cc=agraf@suse.de \
    --cc=bjsdjshi@linux.vnet.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).