* [Qemu-devel] [PATCH 1/1] qemu-img: img_create does not support image-opts, fix docs
@ 2017-04-06 17:45 Jeff Cody
2017-04-06 18:06 ` [Qemu-devel] [PATCH for-2.9 " Eric Blake
2017-04-06 18:18 ` [Qemu-devel] [PATCH " Kevin Wolf
0 siblings, 2 replies; 3+ messages in thread
From: Jeff Cody @ 2017-04-06 17:45 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, kwolf, berrange, mreitz
The documentation and help for qemu-img claims that 'qemu-img create'
will take the '--image-opts' argument. This is not true, so this
patch removes those claims.
Signed-off-by: Jeff Cody <jcody@redhat.com>
---
qemu-img-cmds.hx | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx
index 9c9702c..8ac7822 100644
--- a/qemu-img-cmds.hx
+++ b/qemu-img-cmds.hx
@@ -22,9 +22,9 @@ STEXI
ETEXI
DEF("create", img_create,
- "create [-q] [--object objectdef] [--image-opts] [-f fmt] [-o options] filename [size]")
+ "create [-q] [--object objectdef] [-f fmt] [-o options] filename [size]")
STEXI
-@item create [--object @var{objectdef}] [--image-opts] [-q] [-f @var{fmt}] [-o @var{options}] @var{filename} [@var{size}]
+@item create [--object @var{objectdef}] [-q] [-f @var{fmt}] [-o @var{options}] @var{filename} [@var{size}]
ETEXI
DEF("commit", img_commit,
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH for-2.9 1/1] qemu-img: img_create does not support image-opts, fix docs
2017-04-06 17:45 [Qemu-devel] [PATCH 1/1] qemu-img: img_create does not support image-opts, fix docs Jeff Cody
@ 2017-04-06 18:06 ` Eric Blake
2017-04-06 18:18 ` [Qemu-devel] [PATCH " Kevin Wolf
1 sibling, 0 replies; 3+ messages in thread
From: Eric Blake @ 2017-04-06 18:06 UTC (permalink / raw)
To: Jeff Cody, qemu-devel; +Cc: qemu-trivial, kwolf, mreitz
[-- Attachment #1: Type: text/plain, Size: 566 bytes --]
On 04/06/2017 12:45 PM, Jeff Cody wrote:
> The documentation and help for qemu-img claims that 'qemu-img create'
> will take the '--image-opts' argument. This is not true, so this
> patch removes those claims.
>
> Signed-off-by: Jeff Cody <jcody@redhat.com>
> ---
> qemu-img-cmds.hx | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Doc fix, worth having in 2.9 if we still have time.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH 1/1] qemu-img: img_create does not support image-opts, fix docs
2017-04-06 17:45 [Qemu-devel] [PATCH 1/1] qemu-img: img_create does not support image-opts, fix docs Jeff Cody
2017-04-06 18:06 ` [Qemu-devel] [PATCH for-2.9 " Eric Blake
@ 2017-04-06 18:18 ` Kevin Wolf
1 sibling, 0 replies; 3+ messages in thread
From: Kevin Wolf @ 2017-04-06 18:18 UTC (permalink / raw)
To: Jeff Cody; +Cc: qemu-devel, qemu-trivial, berrange, mreitz
Am 06.04.2017 um 19:45 hat Jeff Cody geschrieben:
> The documentation and help for qemu-img claims that 'qemu-img create'
> will take the '--image-opts' argument. This is not true, so this
> patch removes those claims.
>
> Signed-off-by: Jeff Cody <jcody@redhat.com>
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-06 18:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-06 17:45 [Qemu-devel] [PATCH 1/1] qemu-img: img_create does not support image-opts, fix docs Jeff Cody
2017-04-06 18:06 ` [Qemu-devel] [PATCH for-2.9 " Eric Blake
2017-04-06 18:18 ` [Qemu-devel] [PATCH " Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).