From: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
To: qemu-ppc@nongnu.org, david@gibson.dropbear.id.au, rth@twiddle.net
Cc: qemu-devel@nongnu.org, alex.bennee@linaro.org,
programmingkidx@gmail.com, bharata@linux.vnet.ibm.com,
nikunj@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH v2 2/3] cputlb: handle first atomic write to the page
Date: Fri, 7 Apr 2017 11:37:51 +0530 [thread overview]
Message-ID: <20170407060752.31313-3-nikunj@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170407060752.31313-1-nikunj@linux.vnet.ibm.com>
In case where the conditional write is the first write to the page,
TLB_NOTDIRTY will be set and stop_the_world is triggered. Handle this as
a special case and set the dirty bit. After that fall through to the
actual atomic instruction below.
Signed-off-by: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
Reviewed-by: Richard Henderson <rth@twiddle.net>
---
cputlb.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/cputlb.c b/cputlb.c
index f5d056c..743776a 100644
--- a/cputlb.c
+++ b/cputlb.c
@@ -930,7 +930,13 @@ static void *atomic_mmu_lookup(CPUArchState *env, target_ulong addr,
tlb_addr = tlbe->addr_write;
}
- /* Notice an IO access, or a notdirty page. */
+ /* Check notdirty */
+ if (unlikely(tlb_addr & TLB_NOTDIRTY)) {
+ tlb_set_dirty(ENV_GET_CPU(env), addr);
+ tlb_addr = tlb_addr & ~TLB_NOTDIRTY;
+ }
+
+ /* Notice an IO access */
if (unlikely(tlb_addr & ~TARGET_PAGE_MASK)) {
/* There's really nothing that can be done to
support this apart from stop-the-world. */
--
2.9.3
next prev parent reply other threads:[~2017-04-07 6:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 6:07 [Qemu-devel] [PATCH v2 0/3] Enable MTTCG on PPC64 Nikunj A Dadhania
2017-04-07 6:07 ` [Qemu-devel] [PATCH v2 1/3] target/ppc: Emulate LL/SC using cmpxchg helpers Nikunj A Dadhania
2017-04-07 18:26 ` Richard Henderson
2017-04-07 6:07 ` Nikunj A Dadhania [this message]
2017-04-07 6:07 ` [Qemu-devel] [PATCH v2 3/3] target/ppc: Generate fence operations Nikunj A Dadhania
2017-04-07 18:27 ` Richard Henderson
2017-04-07 17:49 ` [Qemu-devel] [Qemu-ppc] [PATCH v2 0/3] Enable MTTCG on PPC64 luigi burdo
2017-04-07 19:29 ` G 3
2017-04-07 20:11 ` luigi burdo
2017-04-08 11:16 ` luigi burdo
2017-04-09 14:17 ` Alex Bennée
2017-04-08 6:51 ` [Qemu-devel] " David Gibson
2017-04-09 8:41 ` [Qemu-devel] [Qemu-ppc] " luigi burdo
2017-04-09 14:27 ` Alex Bennée
2017-04-09 17:10 ` luigi burdo
2017-04-10 5:43 ` Nikunj A Dadhania
2017-04-10 7:12 ` Alex Bennée
2017-04-10 7:47 ` Nikunj A Dadhania
2017-04-09 17:00 ` [Qemu-devel] " Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170407060752.31313-3-nikunj@linux.vnet.ibm.com \
--to=nikunj@linux.vnet.ibm.com \
--cc=alex.bennee@linaro.org \
--cc=bharata@linux.vnet.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=programmingkidx@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).