* [Qemu-devel] [PATCH 3/3] esp-pci: simple clean up
@ 2017-04-07 6:59 weiqi
2017-04-07 8:49 ` Sahid Orentino Ferdjaoui
0 siblings, 1 reply; 2+ messages in thread
From: weiqi @ 2017-04-07 6:59 UTC (permalink / raw)
To: pbonzini; +Cc: qemu-devel, arei.gonglei, Wei Qi
From: Wei Qi <weiqi4@huawei.com>
It is unnecessary to assign variable 'size' here, because 'size' unused after assignment.
Signed-off-by: Wei Qi <weiqi4@huawei.com>
---
hw/scsi/esp-pci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/scsi/esp-pci.c b/hw/scsi/esp-pci.c
index e295d88..1f5980e 100644
--- a/hw/scsi/esp-pci.c
+++ b/hw/scsi/esp-pci.c
@@ -192,7 +192,6 @@ static void esp_pci_io_write(void *opaque, hwaddr addr,
val <<= shift;
val |= current & ~(mask << shift);
addr &= ~3;
- size = 4;
}
if (addr < 0x40) {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH 3/3] esp-pci: simple clean up
2017-04-07 6:59 [Qemu-devel] [PATCH 3/3] esp-pci: simple clean up weiqi
@ 2017-04-07 8:49 ` Sahid Orentino Ferdjaoui
0 siblings, 0 replies; 2+ messages in thread
From: Sahid Orentino Ferdjaoui @ 2017-04-07 8:49 UTC (permalink / raw)
To: weiqi; +Cc: pbonzini, arei.gonglei, qemu-devel
On Fri, Apr 07, 2017 at 02:59:08PM +0800, weiqi wrote:
> From: Wei Qi <weiqi4@huawei.com>
>
> It is unnecessary to assign variable 'size' here, because 'size' unused after assignment.
>
> Signed-off-by: Wei Qi <weiqi4@huawei.com>
> ---
> hw/scsi/esp-pci.c | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-By: Sahid Orentino Ferdjaoui <sahid.ferdjaoui@redhat.com>
>
> diff --git a/hw/scsi/esp-pci.c b/hw/scsi/esp-pci.c
> index e295d88..1f5980e 100644
> --- a/hw/scsi/esp-pci.c
> +++ b/hw/scsi/esp-pci.c
> @@ -192,7 +192,6 @@ static void esp_pci_io_write(void *opaque, hwaddr addr,
> val <<= shift;
> val |= current & ~(mask << shift);
> addr &= ~3;
> - size = 4;
I verified that 'size' is passed by value to 'esp_pci_io_write(...)',
no loop, no recursivity.
> }
>
> if (addr < 0x40) {
> --
> 1.8.3.1
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-07 8:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-07 6:59 [Qemu-devel] [PATCH 3/3] esp-pci: simple clean up weiqi
2017-04-07 8:49 ` Sahid Orentino Ferdjaoui
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).