Re: [Qemu-devel] [PATCH v3 05/13] qobject: Drop useless QObject casts

[Stefan Hajnoczi <stefanha@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1097 bytes --]

On Wed, Apr 05, 2017 at 02:47:33PM -0500, Eric Blake wrote:
> We have macros in place to make it less verbose to add a subtype
> of QObject to both QDict and QList. While we have made cleanups
> like this in the past (see commit fcfcd8ffc, for example), having
> it be automated by Coccinelle makes it easier to maintain.
> 
> Patch created mechanically via:
>   spatch --sp-file scripts/coccinelle/qobject.cocci \
>     --macro-file scripts/cocci-macro-file.h --dir . --in-place
> then I verified that no manual touchups were required.
> 
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
>  block.c                   | 12 ++++--------
>  block/blkdebug.c          |  4 ++--
>  block/blkverify.c         |  7 +++----
>  block/file-posix.c        |  6 +++---
>  block/file-win32.c        |  4 ++--
>  block/quorum.c            | 16 ++++++----------
>  tests/check-qdict.c       | 20 ++++++++++----------
>  tests/test-qmp-commands.c | 24 ++++++++++++------------
>  8 files changed, 42 insertions(+), 51 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]