From: Kevin Wolf <kwolf@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
qemu-block@nongnu.org, Ed Swierk <eswierk@skyportsystems.com>,
Max Reitz <mreitz@redhat.com>, Eric Blake <eblake@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 0/6] block: Fixes regarding dataplane and management operations
Date: Fri, 7 Apr 2017 14:45:43 +0200 [thread overview]
Message-ID: <20170407124543.GD4716@noname.redhat.com> (raw)
In-Reply-To: <20170407065414.9143-1-famz@redhat.com>
Am 07.04.2017 um 08:54 hat Fam Zheng geschrieben:
> v2: - Drop patch 4 in v1. A second thought made me feel neither it nor Kevin's
> suggestion to move the BH process to bdrv_drain_recurse/BDRV_POLL_WHILE
> is a complete fix. So leave it for a separate patch.
> - Add rev-by to patches 1, 3, 4.
> - Split from patch 1 in v1 and add patch 2, for the new assertions. [Kevin]
> - Rewrite patch 5. Fix block job's co when a BDS is moved to a different
> aio context. [Kevin]
> - Add patch 6.
>
> Crashes are reported on dataplane devices when doing snapshot and commit under
> guest I/O.
>
> With this series, Ed's test case '176' now passes (reran 10+ times):
>
> https://github.com/skyportsystems/qemu-1/commits/eswierk-iotests-2.9
>
> The biggest fix for this is patch 5, which fixes a race condition between main
> thread and iothread.
Thanks, applied patch 1-3 for now. I feel the other patches still need
closer review and potentially discussion.
Kevin
prev parent reply other threads:[~2017-04-07 12:45 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 6:54 [Qemu-devel] [PATCH v2 0/6] block: Fixes regarding dataplane and management operations Fam Zheng
2017-04-07 6:54 ` [Qemu-devel] [PATCH v2 1/6] block: Fix unpaired aio_disable_external in external snapshot Fam Zheng
2017-04-07 13:23 ` Stefan Hajnoczi
2017-04-07 6:54 ` [Qemu-devel] [PATCH v2 2/6] block: Assert attached child node has right aio context Fam Zheng
2017-04-07 13:24 ` Stefan Hajnoczi
2017-04-07 6:54 ` [Qemu-devel] [PATCH v2 3/6] mirror: Fix aio context of mirror_top_bs Fam Zheng
2017-04-07 13:24 ` Stefan Hajnoczi
2017-04-07 6:54 ` [Qemu-devel] [PATCH v2 4/6] block: Quiesce old aio context during bdrv_set_aio_context Fam Zheng
2017-04-07 12:50 ` Stefan Hajnoczi
2017-04-08 3:43 ` Fam Zheng
2017-04-10 8:06 ` Kevin Wolf
2017-04-10 8:45 ` Fam Zheng
2017-04-10 9:11 ` Kevin Wolf
2017-04-07 6:54 ` [Qemu-devel] [PATCH v2 5/6] coroutine: Explicitly specify AioContext when entering coroutine Fam Zheng
2017-04-07 9:57 ` Fam Zheng
2017-04-07 13:26 ` Stefan Hajnoczi
2017-04-08 3:27 ` Fam Zheng
2017-04-07 14:07 ` Eric Blake
2017-04-07 15:14 ` Kevin Wolf
2017-04-10 0:56 ` Paolo Bonzini
2017-04-10 1:43 ` Fam Zheng
2017-04-07 6:54 ` [Qemu-devel] [PATCH v2 6/6] tests/block-job-txn: Don't start block job before adding to txn Fam Zheng
2017-04-07 13:28 ` Stefan Hajnoczi
2017-04-07 18:05 ` John Snow
2017-04-08 3:39 ` Fam Zheng
2017-04-07 12:45 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170407124543.GD4716@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=eblake@redhat.com \
--cc=eswierk@skyportsystems.com \
--cc=famz@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).