From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53545) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cwh21-00077i-GT for qemu-devel@nongnu.org; Fri, 07 Apr 2017 23:27:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cwh20-0000L5-OR for qemu-devel@nongnu.org; Fri, 07 Apr 2017 23:27:21 -0400 Date: Sat, 8 Apr 2017 11:27:08 +0800 From: Fam Zheng Message-ID: <20170408032708.GA6548@lemon> References: <20170407065414.9143-1-famz@redhat.com> <20170407065414.9143-6-famz@redhat.com> <20170407132642.GF16146@stefanha-x1.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170407132642.GF16146@stefanha-x1.localdomain> Subject: Re: [Qemu-devel] [PATCH v2 5/6] coroutine: Explicitly specify AioContext when entering coroutine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Paolo Bonzini , qemu-block@nongnu.org, Ed Swierk , Kevin Wolf , Max Reitz , Eric Blake On Fri, 04/07 14:26, Stefan Hajnoczi wrote: > I wasn't expecting the patch to touch so many places. If a coroutine > can be permanently associated with an AioContext then there's no need to > keep assigning co->ctx on each qemu_coroutine_enter(). Maybe, but bs->job->co->ctx changes when bdrv_set_aio_context(bs->ctx) is called. In v1 the co->ctx is associated at qemu_coroutine_create() time but failed to handle bdrv_set_aio_context. Fam