From: Fam Zheng <famz@redhat.com>
To: 858585 jemmy <jemmy858585@gmail.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
quintela@redhat.com, dgilbert@redhat.com,
Stefan Hajnoczi <stefanha@redhat.com>,
Lidong Chen <lidongchen@tencent.com>
Subject: Re: [Qemu-devel] [PATCH v3] migration/block: use blk_pwrite_zeroes for each zero cluster
Date: Mon, 10 Apr 2017 09:44:55 +0800 [thread overview]
Message-ID: <20170410014455.GB15038@lemon> (raw)
In-Reply-To: <CAOGPPbdkQnTU66wpFcuF7oF4_LcUUED2z7aaBZwMNLjqpLLdGQ@mail.gmail.com>
On Mon, 04/10 09:10, 858585 jemmy wrote:
> >> + if (ret < 0) {
> >> + g_free(buf);
> >> + return ret;
> >> + }
> >
> > This if block is not necessary because...
>
> Hi Fam:
> It's necessary to check each cluster is written successfully.
> if we remove this if block, it maybe ignore some error, and only check
> the last cluster.
> Thanks.
Yes, I missed the fact it is in the loop body. My bad. Thanks for pointint out:
Reviewed-by: Fam Zheng <famz@redhat.com>
next prev parent reply other threads:[~2017-04-10 1:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-09 12:37 [Qemu-devel] [PATCH v3] migration/block: use blk_pwrite_zeroes for each zero cluster jemmy858585
2017-04-10 0:51 ` Fam Zheng
2017-04-10 1:10 ` 858585 jemmy
2017-04-10 1:44 ` Fam Zheng [this message]
2017-04-10 16:00 ` Stefan Hajnoczi
2017-04-11 1:19 ` 858585 jemmy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170410014455.GB15038@lemon \
--to=famz@redhat.com \
--cc=dgilbert@redhat.com \
--cc=jemmy858585@gmail.com \
--cc=lidongchen@tencent.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).