From: "Alex Bennée" <alex.bennee@linaro.org>
To: peter.maydell@linaro.org
Cc: qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>
Subject: [Qemu-devel] [PULL 01/11] scripts/qemugdb/mtree.py: fix up mtree dump
Date: Mon, 10 Apr 2017 13:55:14 +0100 [thread overview]
Message-ID: <20170410125524.21008-2-alex.bennee@linaro.org> (raw)
In-Reply-To: <20170410125524.21008-1-alex.bennee@linaro.org>
Since QEMU has been able to build with native Int128 support this was
broken as it attempts to fish values out of the non-existent
structure. Also the alias print was trying to make a %x out of
gdb.ValueType directly which didn't seem to work.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
diff --git a/scripts/qemugdb/mtree.py b/scripts/qemugdb/mtree.py
index cc8131c2e7..e6791b7885 100644
--- a/scripts/qemugdb/mtree.py
+++ b/scripts/qemugdb/mtree.py
@@ -21,7 +21,15 @@ def isnull(ptr):
return ptr == gdb.Value(0).cast(ptr.type)
def int128(p):
- return int(p['lo']) + (int(p['hi']) << 64)
+ '''Read an Int128 type to a python integer.
+
+ QEMU can be built with native Int128 support so we need to detect
+ if the value is a structure or the native type.
+ '''
+ if p.type.code == gdb.TYPE_CODE_STRUCT:
+ return int(p['lo']) + (int(p['hi']) << 64)
+ else:
+ return int(("%s" % p), 16)
class MtreeCommand(gdb.Command):
'''Display the memory tree hierarchy'''
@@ -69,7 +77,7 @@ class MtreeCommand(gdb.Command):
gdb.write('%s alias: %s@%016x (@ %s)\n' %
(' ' * level,
alias['name'].string(),
- ptr['alias_offset'],
+ int(ptr['alias_offset']),
alias,
),
gdb.STDOUT)
--
2.11.0
next prev parent reply other threads:[~2017-04-10 12:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-10 12:55 [Qemu-devel] [PULL 00/11] Final icount and misc MTTCG fixes for 2.9 Alex Bennée
2017-04-10 12:55 ` Alex Bennée [this message]
2017-04-10 12:55 ` [Qemu-devel] [PULL 02/11] cpus: fix wrong define name Alex Bennée
2017-04-10 12:55 ` [Qemu-devel] [PULL 03/11] target/i386/misc_helper: wrap BQL around another IRQ generator Alex Bennée
2017-04-10 12:55 ` [Qemu-devel] [PULL 04/11] cpus: remove icount handling from qemu_tcg_cpu_thread_fn Alex Bennée
2017-04-10 12:55 ` [Qemu-devel] [PULL 05/11] cpus: check cpu->running in cpu_get_icount_raw() Alex Bennée
2017-04-10 12:55 ` [Qemu-devel] [PULL 06/11] cpus: move icount preparation out of tcg_exec_cpu Alex Bennée
2017-04-10 12:55 ` [Qemu-devel] [PULL 07/11] cpus: don't credit executed instructions before they have run Alex Bennée
2017-04-10 12:55 ` [Qemu-devel] [PULL 08/11] cpus: introduce cpu_update_icount helper Alex Bennée
2017-04-10 12:55 ` [Qemu-devel] [PULL 09/11] cpu-exec: update icount after each TB_EXIT Alex Bennée
2017-04-10 12:55 ` [Qemu-devel] [PULL 10/11] cpus: call cpu_update_icount on read Alex Bennée
2017-04-10 12:55 ` [Qemu-devel] [PULL 11/11] replay: assert time only goes forward Alex Bennée
2017-04-10 15:08 ` [Qemu-devel] [PULL 00/11] Final icount and misc MTTCG fixes for 2.9 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170410125524.21008-2-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).