From: "Alex Bennée" <alex.bennee@linaro.org>
To: peter.maydell@linaro.org
Cc: qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Richard Henderson" <rth@twiddle.net>,
"Eduardo Habkost" <ehabkost@redhat.com>
Subject: [Qemu-devel] [PULL 03/11] target/i386/misc_helper: wrap BQL around another IRQ generator
Date: Mon, 10 Apr 2017 13:55:16 +0100 [thread overview]
Message-ID: <20170410125524.21008-4-alex.bennee@linaro.org> (raw)
In-Reply-To: <20170410125524.21008-1-alex.bennee@linaro.org>
Anything that calls into HW emulation must be protected by the BQL.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <rth@twiddle.net>
Acked-by: Eduardo Habkost <ehabkost@redhat.com>
diff --git a/target/i386/misc_helper.c b/target/i386/misc_helper.c
index ca2ea09f54..628f64aad5 100644
--- a/target/i386/misc_helper.c
+++ b/target/i386/misc_helper.c
@@ -18,6 +18,7 @@
*/
#include "qemu/osdep.h"
+#include "qemu/main-loop.h"
#include "cpu.h"
#include "exec/helper-proto.h"
#include "exec/exec-all.h"
@@ -156,7 +157,9 @@ void helper_write_crN(CPUX86State *env, int reg, target_ulong t0)
break;
case 8:
if (!(env->hflags2 & HF2_VINTR_MASK)) {
+ qemu_mutex_lock_iothread();
cpu_set_apic_tpr(x86_env_get_cpu(env)->apic_state, t0);
+ qemu_mutex_unlock_iothread();
}
env->v_tpr = t0 & 0x0f;
break;
--
2.11.0
next prev parent reply other threads:[~2017-04-10 12:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-10 12:55 [Qemu-devel] [PULL 00/11] Final icount and misc MTTCG fixes for 2.9 Alex Bennée
2017-04-10 12:55 ` [Qemu-devel] [PULL 01/11] scripts/qemugdb/mtree.py: fix up mtree dump Alex Bennée
2017-04-10 12:55 ` [Qemu-devel] [PULL 02/11] cpus: fix wrong define name Alex Bennée
2017-04-10 12:55 ` Alex Bennée [this message]
2017-04-10 12:55 ` [Qemu-devel] [PULL 04/11] cpus: remove icount handling from qemu_tcg_cpu_thread_fn Alex Bennée
2017-04-10 12:55 ` [Qemu-devel] [PULL 05/11] cpus: check cpu->running in cpu_get_icount_raw() Alex Bennée
2017-04-10 12:55 ` [Qemu-devel] [PULL 06/11] cpus: move icount preparation out of tcg_exec_cpu Alex Bennée
2017-04-10 12:55 ` [Qemu-devel] [PULL 07/11] cpus: don't credit executed instructions before they have run Alex Bennée
2017-04-10 12:55 ` [Qemu-devel] [PULL 08/11] cpus: introduce cpu_update_icount helper Alex Bennée
2017-04-10 12:55 ` [Qemu-devel] [PULL 09/11] cpu-exec: update icount after each TB_EXIT Alex Bennée
2017-04-10 12:55 ` [Qemu-devel] [PULL 10/11] cpus: call cpu_update_icount on read Alex Bennée
2017-04-10 12:55 ` [Qemu-devel] [PULL 11/11] replay: assert time only goes forward Alex Bennée
2017-04-10 15:08 ` [Qemu-devel] [PULL 00/11] Final icount and misc MTTCG fixes for 2.9 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170410125524.21008-4-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).