Re: [Qemu-devel] [PATCH v3 1/2] hw/acpi-defs: replace leading X with x_ in FADT field names

["Michael S. Tsirkin" <mst@redhat.com>]

On Mon, Apr 10, 2017 at 05:28:44PM +0200, Laszlo Ersek wrote:
> On 04/10/17 17:03, Ard Biesheuvel wrote:
> > At the request of Michael, replace the leading capital X in the FADT
> > field name Xfacs and Xdsdt with lower case x + underscore.
> > 
> > Cc: Michael S. Tsirkin <mst@redhat.com>
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > ---
> >  include/hw/acpi/acpi-defs.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/include/hw/acpi/acpi-defs.h b/include/hw/acpi/acpi-defs.h
> > index 4cc3630e613e..db48807056b3 100644
> > --- a/include/hw/acpi/acpi-defs.h
> > +++ b/include/hw/acpi/acpi-defs.h
> > @@ -165,8 +165,8 @@ struct AcpiFadtDescriptorRev5_1 {
> >      /* ARM-Specific Boot Flags (see below for individual flags) (ACPI 5.1) */
> >      uint16_t arm_boot_flags;
> >      uint8_t minor_revision;  /* FADT Minor Revision (ACPI 5.1) */
> > -    uint64_t Xfacs;          /* 64-bit physical address of FACS */
> > -    uint64_t Xdsdt;          /* 64-bit physical address of DSDT */
> > +    uint64_t x_facs;         /* 64-bit physical address of FACS */
> > +    uint64_t x_dsdt;         /* 64-bit physical address of DSDT */
> >      /* 64-bit Extended Power Mgt 1a Event Reg Blk address */
> >      struct AcpiGenericAddress xpm1a_event_block;
> >      /* 64-bit Extended Power Mgt 1b Event Reg Blk address */
> > 
> 
> (This is for 2.10, or whatever comes after 2.9.)
> 
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks, pls remember to repost after 2.9 is out.