* [Qemu-devel] [PATCH] target/ppc: Fix size of struct PPCElfPrstatus
@ 2017-04-11 6:04 Anton Blanchard
2017-04-11 6:15 ` David Gibson
0 siblings, 1 reply; 2+ messages in thread
From: Anton Blanchard @ 2017-04-11 6:04 UTC (permalink / raw)
To: david, agraf, aneesh.kumar; +Cc: qemu-ppc, qemu-devel
From: Anton Blanchard <anton@samba.org>
gdb refuses to parse QEMU memory dumps because struct PPCElfPrstatus
is the wrong size. Fix it.
Signed-off-by: Anton Blanchard <anton@samba.org>
Fixes: e62fbc54d459 ("target-ppc: dump-guest-memory support")
---
target/ppc/arch_dump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/ppc/arch_dump.c b/target/ppc/arch_dump.c
index 28d9cc7d79..8e9397aa58 100644
--- a/target/ppc/arch_dump.c
+++ b/target/ppc/arch_dump.c
@@ -50,7 +50,7 @@ struct PPCUserRegStruct {
struct PPCElfPrstatus {
char pad1[112];
struct PPCUserRegStruct pr_reg;
- reg_t pad2[4];
+ char pad2[40];
} QEMU_PACKED;
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] target/ppc: Fix size of struct PPCElfPrstatus
2017-04-11 6:04 [Qemu-devel] [PATCH] target/ppc: Fix size of struct PPCElfPrstatus Anton Blanchard
@ 2017-04-11 6:15 ` David Gibson
0 siblings, 0 replies; 2+ messages in thread
From: David Gibson @ 2017-04-11 6:15 UTC (permalink / raw)
To: Anton Blanchard; +Cc: agraf, aneesh.kumar, qemu-ppc, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 1046 bytes --]
On Tue, Apr 11, 2017 at 04:04:56PM +1000, Anton Blanchard wrote:
> From: Anton Blanchard <anton@samba.org>
>
> gdb refuses to parse QEMU memory dumps because struct PPCElfPrstatus
> is the wrong size. Fix it.
>
> Signed-off-by: Anton Blanchard <anton@samba.org>
> Fixes: e62fbc54d459 ("target-ppc: dump-guest-memory support")
Applied to ppc-for-2.10, thanks.
> ---
> target/ppc/arch_dump.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/ppc/arch_dump.c b/target/ppc/arch_dump.c
> index 28d9cc7d79..8e9397aa58 100644
> --- a/target/ppc/arch_dump.c
> +++ b/target/ppc/arch_dump.c
> @@ -50,7 +50,7 @@ struct PPCUserRegStruct {
> struct PPCElfPrstatus {
> char pad1[112];
> struct PPCUserRegStruct pr_reg;
> - reg_t pad2[4];
> + char pad2[40];
> } QEMU_PACKED;
>
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-11 6:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-11 6:04 [Qemu-devel] [PATCH] target/ppc: Fix size of struct PPCElfPrstatus Anton Blanchard
2017-04-11 6:15 ` David Gibson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).