From: David Gibson <david@gibson.dropbear.id.au>
To: Anton Blanchard <anton@ozlabs.org>
Cc: agraf@suse.de, aneesh.kumar@linux.vnet.ibm.com,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] target/ppc: Fix size of struct PPCElfPrstatus
Date: Tue, 11 Apr 2017 16:15:35 +1000 [thread overview]
Message-ID: <20170411061535.GB12900@umbus.fritz.box> (raw)
In-Reply-To: <20170411060456.21594-1-anton@ozlabs.org>
[-- Attachment #1: Type: text/plain, Size: 1046 bytes --]
On Tue, Apr 11, 2017 at 04:04:56PM +1000, Anton Blanchard wrote:
> From: Anton Blanchard <anton@samba.org>
>
> gdb refuses to parse QEMU memory dumps because struct PPCElfPrstatus
> is the wrong size. Fix it.
>
> Signed-off-by: Anton Blanchard <anton@samba.org>
> Fixes: e62fbc54d459 ("target-ppc: dump-guest-memory support")
Applied to ppc-for-2.10, thanks.
> ---
> target/ppc/arch_dump.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/ppc/arch_dump.c b/target/ppc/arch_dump.c
> index 28d9cc7d79..8e9397aa58 100644
> --- a/target/ppc/arch_dump.c
> +++ b/target/ppc/arch_dump.c
> @@ -50,7 +50,7 @@ struct PPCUserRegStruct {
> struct PPCElfPrstatus {
> char pad1[112];
> struct PPCUserRegStruct pr_reg;
> - reg_t pad2[4];
> + char pad2[40];
> } QEMU_PACKED;
>
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2017-04-11 6:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 6:04 [Qemu-devel] [PATCH] target/ppc: Fix size of struct PPCElfPrstatus Anton Blanchard
2017-04-11 6:15 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170411061535.GB12900@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=agraf@suse.de \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=anton@ozlabs.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).