From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43995) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cxrje-0004ZN-EZ for qemu-devel@nongnu.org; Tue, 11 Apr 2017 05:05:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cxrja-0000Fm-FY for qemu-devel@nongnu.org; Tue, 11 Apr 2017 05:05:14 -0400 Date: Tue, 11 Apr 2017 11:04:57 +0200 From: Kevin Wolf Message-ID: <20170411090457.GF4516@noname.str.redhat.com> References: <20170410150542.30376-1-famz@redhat.com> <20170410150542.30376-4-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170410150542.30376-4-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH for 2.9 v3 03/10] tests/block-job-txn: Don't start block job before adding to txn List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: qemu-devel@nongnu.org, Paolo Bonzini , qemu-block@nongnu.org, Ed Swierk , Max Reitz , Eric Blake , Stefan Hajnoczi Am 10.04.2017 um 17:05 hat Fam Zheng geschrieben: > Previously, before test_block_job_start returns, the job can already > complete, as a result, the transactional state of other jobs added to > the same txn later cannot be handled correctly. > > Move the block_job_start() calls to callers after > block_job_txn_add_job() calls. > > Signed-off-by: Fam Zheng Reviewed-by: Kevin Wolf