qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: armbru@redhat.com
Subject: [Qemu-devel] [PATCH v4 11/13] QemuOpts: Simplify qemu_opts_to_qdict()
Date: Tue, 11 Apr 2017 13:50:32 -0500	[thread overview]
Message-ID: <20170411185034.13460-12-eblake@redhat.com> (raw)
In-Reply-To: <20170411185034.13460-1-eblake@redhat.com>

Noticed while investigating Coccinelle cleanups. There is no need
for a temporary variable when we can use the new macro to do the
same thing with less typing.

Signed-off-by: Eric Blake <eblake@redhat.com>
---
 util/qemu-option.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/util/qemu-option.c b/util/qemu-option.c
index a36cafa..5977bfc 100644
--- a/util/qemu-option.c
+++ b/util/qemu-option.c
@@ -1054,7 +1054,6 @@ void qemu_opts_absorb_qdict(QemuOpts *opts, QDict *qdict, Error **errp)
 QDict *qemu_opts_to_qdict(QemuOpts *opts, QDict *qdict)
 {
     QemuOpt *opt;
-    QObject *val;

     if (!qdict) {
         qdict = qdict_new();
@@ -1063,8 +1062,7 @@ QDict *qemu_opts_to_qdict(QemuOpts *opts, QDict *qdict)
         qdict_put_str(qdict, "id", opts->id);
     }
     QTAILQ_FOREACH(opt, &opts->head, next) {
-        val = QOBJECT(qstring_from_str(opt->str));
-        qdict_put_obj(qdict, opt->name, val);
+        qdict_put_str(qdict, opt->name, opt->str);
     }
     return qdict;
 }
-- 
2.9.3

  parent reply	other threads:[~2017-04-11 18:51 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-11 18:50 [Qemu-devel] [PATCH v4 00/13] qapi-related cleanups Eric Blake
2017-04-11 18:50 ` [Qemu-devel] [PATCH v4 01/13] pci: Use struct instead of QDict to pass back parameters Eric Blake
2017-04-11 18:50 ` [Qemu-devel] [PATCH v4 02/13] pci: Reduce scope of error injection Eric Blake
2017-04-11 18:50 ` [Qemu-devel] [PATCH v4 03/13] s390x: Drop useless casts Eric Blake
2017-04-11 18:50 ` [Qemu-devel] [PATCH v4 04/13] coccinelle: Add script to remove useless QObject casts Eric Blake
2017-04-11 18:50 ` [Qemu-devel] [PATCH v4 05/13] qobject: Drop " Eric Blake
2017-04-12 13:06   ` Alberto Garcia
2017-04-11 18:50 ` [Qemu-devel] [PATCH v4 06/13] qobject: Add helper macros for common scalar insertions Eric Blake
2017-04-12  6:40   ` Markus Armbruster
2017-04-12 13:17     ` Eric Blake
2017-04-11 18:50 ` [Qemu-devel] [PATCH v4 07/13] block: Use simpler QDict/QList scalar insertion macros Eric Blake
2017-04-12  6:52   ` Markus Armbruster
2017-04-12 13:18     ` Eric Blake
2017-04-12 13:09   ` Alberto Garcia
2017-04-11 18:50 ` [Qemu-devel] [PATCH v4 08/13] tests: " Eric Blake
2017-04-12  3:14   ` Philippe Mathieu-Daudé
2017-04-11 18:50 ` [Qemu-devel] [PATCH v4 09/13] qobject: " Eric Blake
2017-04-12  4:25   ` Philippe Mathieu-Daudé
2017-04-11 18:50 ` [Qemu-devel] [PATCH v4 10/13] block: Simplify bdrv_append_temp_snapshot() logic Eric Blake
2017-04-11 18:50 ` Eric Blake [this message]
2017-04-12  3:15   ` [Qemu-devel] [PATCH v4 11/13] QemuOpts: Simplify qemu_opts_to_qdict() Philippe Mathieu-Daudé
2017-04-11 18:50 ` [Qemu-devel] [PATCH v4 12/13] fdc-test: Avoid deprecated 'change' command Eric Blake
2017-04-11 20:44   ` John Snow
2017-04-11 18:50 ` [Qemu-devel] [PATCH v4 13/13] test-qga: Actually test 0xff sync bytes Eric Blake
2017-04-12  6:54 ` [Qemu-devel] [PATCH v4 00/13] qapi-related cleanups Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170411185034.13460-12-eblake@redhat.com \
    --to=eblake@redhat.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).