From: Kevin Wolf <kwolf@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-block@nongnu.org, mreitz@redhat.com, quintela@redhat.com,
dgilbert@redhat.com, stefanha@redhat.com, lvivier@redhat.com,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/3] migration: Call blk_resume_after_migration() for postcopy
Date: Thu, 13 Apr 2017 19:54:44 +0200 [thread overview]
Message-ID: <20170413175444.GG5095@noname.redhat.com> (raw)
In-Reply-To: <a635dc96-283e-3704-59cb-248eb065bf2b@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 865 bytes --]
Am 13.04.2017 um 19:39 hat Eric Blake geschrieben:
> On 04/13/2017 12:23 PM, Kevin Wolf wrote:
> > Commit d35ff5e6 ('block: Ignore guest dev permissions during incoming
> > migration') added blk_resume_after_migration() to the precopy migration
> > path, but neglected to add it to the duplicated code that is used for
> > postcopy migration. This means that the guest device doesn't request the
> > necessary permissions, which ultimately led to failing assertions.
> >
> > Add the missing blk_resume_after_migration() to the postcopy path.
> >
> > Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> > ---
> > migration/savevm.c | 8 ++++++++
> > 1 file changed, 8 insertions(+)
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
> Are we targetting this for 2.9-rc5, or is it 2.10 material?
At this point, I think it's clearly 2.10.
Kevin
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2017-04-13 17:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 17:23 [Qemu-devel] [PATCH 0/3] migration: Call blk_resume_after_migration() for postcopy Kevin Wolf
2017-04-13 17:23 ` [Qemu-devel] [PATCH 1/3] " Kevin Wolf
2017-04-13 17:39 ` Eric Blake
2017-04-13 17:54 ` Kevin Wolf [this message]
2017-04-13 18:03 ` Eric Blake
2017-04-13 18:30 ` Kevin Wolf
2017-04-13 17:23 ` [Qemu-devel] [PATCH 2/3] qemu-iotests: Filter HMP readline escape characters Kevin Wolf
2017-04-13 17:38 ` Eric Blake
2017-04-13 17:44 ` Eric Blake
2017-04-19 14:45 ` Kevin Wolf
2017-04-13 17:23 ` [Qemu-devel] [PATCH 3/3] qemu-iotests: Test postcopy migration Kevin Wolf
2017-04-13 18:44 ` Eric Blake
2017-04-19 14:38 ` Kevin Wolf
2017-04-18 12:04 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170413175444.GG5095@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=lvivier@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).