From: Fam Zheng <famz@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] util/error: Fix leak in error_vprepend()
Date: Mon, 17 Apr 2017 15:08:06 +0800 [thread overview]
Message-ID: <20170417070806.GB13582@lemon.lan> (raw)
In-Reply-To: <20170413160952.29918-1-mreitz@redhat.com>
On Thu, 04/13 18:09, Max Reitz wrote:
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> util/error.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/util/error.c b/util/error.c
> index 9c40b1f458..020b86b9f0 100644
> --- a/util/error.c
> +++ b/util/error.c
> @@ -134,6 +134,7 @@ void error_vprepend(Error **errp, const char *fmt, va_list ap)
> newmsg = g_string_new(NULL);
> g_string_vprintf(newmsg, fmt, ap);
> g_string_append(newmsg, (*errp)->msg);
> + g_free((*errp)->msg);
> (*errp)->msg = g_string_free(newmsg, 0);
> }
>
> --
> 2.12.2
>
>
Reviewed-by: Fam Zheng <famz@redhat.com>
next prev parent reply other threads:[~2017-04-17 7:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 16:09 [Qemu-devel] [PATCH] util/error: Fix leak in error_vprepend() Max Reitz
2017-04-17 7:08 ` Fam Zheng [this message]
2017-04-17 11:28 ` Jeff Cody
2017-04-20 16:07 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170417070806.GB13582@lemon.lan \
--to=famz@redhat.com \
--cc=armbru@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).