qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: ZhiPeng Lu <lu.zhipeng@zte.com.cn>
Cc: mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qemu-ga: add guest-network-get-interface-stat command
Date: Wed, 19 Apr 2017 10:21:52 +0100	[thread overview]
Message-ID: <20170419092152.GF4019@redhat.com> (raw)
In-Reply-To: <1492621028-16280-1-git-send-email-lu.zhipeng@zte.com.cn>

On Thu, Apr 20, 2017 at 12:57:08AM +0800, ZhiPeng Lu wrote:
> we can get the  network card statistics inside  a virtual machine by
> guest-network-get-interface-stat command.
> it is very userful for us to monitor and analyze network traff.

In most cases you can already monitor guest network traffic from the
statistics on the QEMU backend device (ie tap device). The exception
is when doing PCI device assignment. Is the latter the reason why you
need to add this functionality instead of just quuerying the host
backend ?

There have been a lot of proposals for new QEMU geust agent commands in
the past few weeks

 - NIC statistics
 - Logged in users
 - Timezone offset
 - Hostname
 - OS version / product

This makes me wonder what our intended scope is for the guest agent ? Are we
happy to add arbitrary functionality to the guest agent, allowing it grow in
size & complexity without bound. Or is it better to restrict it to tasks which
are needed in order to coordinate management of the host virtualization layer
and leave general purpose guest OS management to another app.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

  reply	other threads:[~2017-04-19  9:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-19 16:57 [Qemu-devel] [PATCH] qemu-ga: add guest-network-get-interface-stat command ZhiPeng Lu
2017-04-19  9:21 ` Daniel P. Berrange [this message]
2017-04-19 11:41 ` Cornelia Huck
2017-04-19 11:50   ` Daniel P. Berrange
2017-04-19 11:57     ` Cornelia Huck
2017-04-19 13:34 ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170419092152.GF4019@redhat.com \
    --to=berrange@redhat.com \
    --cc=lu.zhipeng@zte.com.cn \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).