qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: dgilbert@redhat.com
Subject: [Qemu-devel] [PATCH 42/59] ram: We don't need MigrationState parameter anymore
Date: Wed, 19 Apr 2017 22:59:06 +0200	[thread overview]
Message-ID: <20170419205923.8808-43-quintela@redhat.com> (raw)
In-Reply-To: <20170419205923.8808-1-quintela@redhat.com>

Remove it from callers and callees.

Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
---
 migration/ram.c | 27 ++++++++++-----------------
 1 file changed, 10 insertions(+), 17 deletions(-)

diff --git a/migration/ram.c b/migration/ram.c
index 289d7eb..fe01e7b 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -794,13 +794,11 @@ static void ram_release_pages(const char *rbname, uint64_t offset, int pages)
  *                if xbzrle noticed the page was the same.
  *
  * @rs: current RAM state
- * @ms: current migration state
  * @block: block that contains the page we want to send
  * @offset: offset inside the block for the page
  * @last_stage: if we are at the completion stage
  */
-static int ram_save_page(RAMState *rs, MigrationState *ms,
-                         PageSearchStatus *pss, bool last_stage)
+static int ram_save_page(RAMState *rs, PageSearchStatus *pss, bool last_stage)
 {
     int pages = -1;
     uint64_t bytes_xmit;
@@ -974,13 +972,12 @@ static int compress_page_with_multi_thread(RAMState *rs, RAMBlock *block,
  * Returns the number of pages written.
  *
  * @rs: current RAM state
- * @ms: current migration state
  * @block: block that contains the page we want to send
  * @offset: offset inside the block for the page
  * @last_stage: if we are at the completion stage
  */
-static int ram_save_compressed_page(RAMState *rs, MigrationState *ms,
-                                    PageSearchStatus *pss, bool last_stage)
+static int ram_save_compressed_page(RAMState *rs, PageSearchStatus *pss,
+                                    bool last_stage)
 {
     int pages = -1;
     uint64_t bytes_xmit = 0;
@@ -1311,10 +1308,8 @@ err:
  * @last_stage: if we are at the completion stage
  * @dirty_ram_abs: address of the start of the dirty page in ram_addr_t space
  */
-static int ram_save_target_page(RAMState *rs, MigrationState *ms,
-                                PageSearchStatus *pss,
-                                bool last_stage,
-                                ram_addr_t dirty_ram_abs)
+static int ram_save_target_page(RAMState *rs, PageSearchStatus *pss,
+                                bool last_stage, ram_addr_t dirty_ram_abs)
 {
     int res = 0;
 
@@ -1329,9 +1324,9 @@ static int ram_save_target_page(RAMState *rs, MigrationState *ms,
 
         if (migrate_use_compression()
             && (rs->ram_bulk_stage || !migrate_use_xbzrle())) {
-            res = ram_save_compressed_page(rs, ms, pss, last_stage);
+            res = ram_save_compressed_page(rs, pss, last_stage);
         } else {
-            res = ram_save_page(rs, ms, pss, last_stage);
+            res = ram_save_page(rs, pss, last_stage);
         }
 
         if (res < 0) {
@@ -1370,8 +1365,7 @@ static int ram_save_target_page(RAMState *rs, MigrationState *ms,
  * @last_stage: if we are at the completion stage
  * @dirty_ram_abs: Address of the start of the dirty page in ram_addr_t space
  */
-static int ram_save_host_page(RAMState *rs, MigrationState *ms,
-                              PageSearchStatus *pss,
+static int ram_save_host_page(RAMState *rs, PageSearchStatus *pss,
                               bool last_stage,
                               ram_addr_t dirty_ram_abs)
 {
@@ -1379,7 +1373,7 @@ static int ram_save_host_page(RAMState *rs, MigrationState *ms,
     size_t pagesize = qemu_ram_pagesize(pss->block);
 
     do {
-        tmppages = ram_save_target_page(rs, ms, pss, last_stage, dirty_ram_abs);
+        tmppages = ram_save_target_page(rs, pss, last_stage, dirty_ram_abs);
         if (tmppages < 0) {
             return tmppages;
         }
@@ -1411,7 +1405,6 @@ static int ram_save_host_page(RAMState *rs, MigrationState *ms,
 static int ram_find_and_save_block(RAMState *rs, bool last_stage)
 {
     PageSearchStatus pss;
-    MigrationState *ms = migrate_get_current();
     int pages = 0;
     bool again, found;
     ram_addr_t dirty_ram_abs; /* Address of the start of the dirty page in
@@ -1440,7 +1433,7 @@ static int ram_find_and_save_block(RAMState *rs, bool last_stage)
         }
 
         if (found) {
-            pages = ram_save_host_page(rs, ms, &pss, last_stage, dirty_ram_abs);
+            pages = ram_save_host_page(rs, &pss, last_stage, dirty_ram_abs);
         }
     } while (!pages && again);
 
-- 
2.9.3

  parent reply	other threads:[~2017-04-19 21:00 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-19 20:58 [Qemu-devel] [PATCH 00/59] RAMState + qdev Juan Quintela
2017-04-19 20:58 ` [Qemu-devel] [PATCH 01/59] ram: Update all functions comments Juan Quintela
2017-04-19 20:58 ` [Qemu-devel] [PATCH 02/59] ram: Rename flush_page_queue() to migration_page_queue_free() Juan Quintela
2017-04-19 20:58 ` [Qemu-devel] [PATCH 03/59] ram: Rename block_name to rbname Juan Quintela
2017-04-19 20:58 ` [Qemu-devel] [PATCH 04/59] ram: Create RAMState Juan Quintela
2017-04-19 20:58 ` [Qemu-devel] [PATCH 05/59] ram: Add dirty_rate_high_cnt to RAMState Juan Quintela
2017-04-19 20:58 ` [Qemu-devel] [PATCH 06/59] ram: Move bitmap_sync_count into RAMState Juan Quintela
2017-04-19 20:58 ` [Qemu-devel] [PATCH 07/59] ram: Move start time " Juan Quintela
2017-04-19 20:58 ` [Qemu-devel] [PATCH 08/59] ram: Move bytes_xfer_prev " Juan Quintela
2017-04-19 20:58 ` [Qemu-devel] [PATCH 09/59] ram: Change byte_xfer_{prev, now} type to uint64_t Juan Quintela
2017-04-19 20:58 ` [Qemu-devel] [PATCH 10/59] ram: Move num_dirty_pages_period into RAMState Juan Quintela
2017-04-19 20:58 ` [Qemu-devel] [PATCH 11/59] ram: Change num_dirty_pages_period type to uint64_t Juan Quintela
2017-04-19 20:58 ` [Qemu-devel] [PATCH 12/59] ram: Move xbzrle_cache_miss_prev into RAMState Juan Quintela
2017-04-19 20:58 ` [Qemu-devel] [PATCH 13/59] ram: Move iterations_prev " Juan Quintela
2017-04-19 20:58 ` [Qemu-devel] [PATCH 14/59] ram: Move dup_pages " Juan Quintela
2017-04-19 20:58 ` [Qemu-devel] [PATCH 15/59] ram: Remove unused dup_mig_bytes_transferred() Juan Quintela
2017-04-19 20:58 ` [Qemu-devel] [PATCH 16/59] ram: Remove unused pages_skipped variable Juan Quintela
2017-04-19 20:58 ` [Qemu-devel] [PATCH 17/59] ram: Move norm_pages to RAMState Juan Quintela
2017-04-19 20:58 ` [Qemu-devel] [PATCH 18/59] ram: Remove norm_mig_bytes_transferred Juan Quintela
2017-04-19 20:58 ` [Qemu-devel] [PATCH 19/59] ram: Move iterations into RAMState Juan Quintela
2017-04-19 20:58 ` [Qemu-devel] [PATCH 20/59] ram: Move xbzrle_bytes " Juan Quintela
2017-04-19 20:58 ` [Qemu-devel] [PATCH 21/59] ram: Move xbzrle_pages " Juan Quintela
2017-04-19 20:58 ` [Qemu-devel] [PATCH 22/59] ram: Move xbzrle_cache_miss " Juan Quintela
2017-04-19 20:58 ` [Qemu-devel] [PATCH 23/59] ram: Move xbzrle_cache_miss_rate " Juan Quintela
2017-04-19 20:58 ` [Qemu-devel] [PATCH 24/59] ram: Move xbzrle_overflows " Juan Quintela
2017-04-19 20:58 ` [Qemu-devel] [PATCH 25/59] ram: Move migration_dirty_pages to RAMState Juan Quintela
2017-04-19 20:58 ` [Qemu-devel] [PATCH 26/59] ram: Everything was init to zero, so use memset Juan Quintela
2017-04-19 20:58 ` [Qemu-devel] [PATCH 27/59] ram: Move migration_bitmap_mutex into RAMState Juan Quintela
2017-04-19 20:58 ` [Qemu-devel] [PATCH 28/59] ram: Move migration_bitmap_rcu " Juan Quintela
2017-04-19 20:58 ` [Qemu-devel] [PATCH 29/59] ram: Move bytes_transferred " Juan Quintela
2017-04-19 20:58 ` [Qemu-devel] [PATCH 30/59] ram: Use the RAMState bytes_transferred parameter Juan Quintela
2017-04-19 20:58 ` [Qemu-devel] [PATCH 31/59] ram: Remove ram_save_remaining Juan Quintela
2017-04-19 20:58 ` [Qemu-devel] [PATCH 32/59] ram: Move last_req_rb to RAMState Juan Quintela
2017-04-19 20:58 ` [Qemu-devel] [PATCH 33/59] ram: Move src_page_req* " Juan Quintela
2017-04-19 20:58 ` [Qemu-devel] [PATCH 34/59] ram: Create ram_dirty_sync_count() Juan Quintela
2017-04-19 20:58 ` [Qemu-devel] [PATCH 35/59] ram: Remove dirty_bytes_rate Juan Quintela
2017-04-19 20:59 ` [Qemu-devel] [PATCH 36/59] ram: Move dirty_pages_rate to RAMState Juan Quintela
2017-04-19 20:59 ` [Qemu-devel] [PATCH 37/59] ram: Move postcopy_requests into RAMState Juan Quintela
2017-04-19 20:59 ` [Qemu-devel] [PATCH 38/59] ram: Add QEMUFile to RAMState Juan Quintela
2017-04-19 20:59 ` [Qemu-devel] [PATCH 39/59] ram: Move QEMUFile into RAMState Juan Quintela
2017-04-19 20:59 ` [Qemu-devel] [PATCH 40/59] ram: Remove compression_switch and inline its logic Juan Quintela
2017-04-19 20:59 ` [Qemu-devel] [PATCH 41/59] migration: Remove MigrationState from migration_in_postcopy Juan Quintela
2017-04-19 20:59 ` Juan Quintela [this message]
2017-04-19 20:59 ` [Qemu-devel] [PATCH 43/59] ram: Rename qemu_target_page_bits() to qemu_target_page_size() Juan Quintela
2017-04-19 20:59 ` [Qemu-devel] [PATCH 44/59] ram: Add page-size to output in 'info migrate' Juan Quintela
2017-04-19 20:59 ` [Qemu-devel] [PATCH 45/59] ram: Pass RAMBlock to bitmap_sync Juan Quintela
2017-04-19 20:59 ` [Qemu-devel] [PATCH 46/59] ram: ram_discard_range() don't use the mis parameter Juan Quintela
2017-04-19 20:59 ` [Qemu-devel] [PATCH 47/59] ram: reorganize last_sent_block Juan Quintela
2017-04-19 20:59 ` [Qemu-devel] [PATCH 48/59] ram: Use page number instead of an address for the bitmap operations Juan Quintela
2017-04-19 20:59 ` [Qemu-devel] [PATCH 49/59] ram: Remember last_page instead of last_offset Juan Quintela
2017-04-19 22:17   ` Philippe Mathieu-Daudé
2017-04-21  9:26     ` Juan Quintela
2017-04-20  8:57   ` Dr. David Alan Gilbert
2017-04-19 20:59 ` [Qemu-devel] [PATCH 50/59] ram: Change offset field in PageSearchStatus to page Juan Quintela
2017-04-19 20:59 ` [Qemu-devel] [PATCH 51/59] ram: Use ramblock and page offset instead of absolute offset Juan Quintela
2017-04-19 20:59 ` [Qemu-devel] [PATCH 52/59] ram: rename last_ram_offset() last_ram_pages() Juan Quintela
2017-04-19 20:59 ` [Qemu-devel] [PATCH 53/59] ram: Use RAMBitmap type for coherence Juan Quintela
2017-04-19 20:59 ` [Qemu-devel] [PATCH 54/59] migration: Remove MigrationState parameter from migration_is_idle() Juan Quintela
2017-04-19 20:59 ` [Qemu-devel] [PATCH 55/59] qdev: qdev_hotplug is really a bool Juan Quintela
2017-04-19 20:59 ` [Qemu-devel] [PATCH 56/59] qdev: Export qdev_hot_removed Juan Quintela
2017-04-19 20:59 ` [Qemu-devel] [PATCH 57/59] qdev: Move qdev_unplug() to qdev-monitor.c Juan Quintela
2017-04-19 20:59 ` [Qemu-devel] [PATCH 58/59] migration: Disable hotplug/unplug during migration Juan Quintela
2017-04-19 20:59 ` [Qemu-devel] [PATCH 59/59] ram: Remove migration_bitmap_extend() Juan Quintela
2017-04-19 21:49 ` [Qemu-devel] [PATCH 00/59] RAMState + qdev no-reply
2017-04-20  7:35   ` Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170419205923.8808-43-quintela@redhat.com \
    --to=quintela@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).