From: Fam Zheng <famz@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] iotests: 109: Filter out "len" of failed jobs
Date: Thu, 20 Apr 2017 08:53:22 +0800 [thread overview]
Message-ID: <20170420005322.GC25568@lemon.lan> (raw)
In-Reply-To: <a3c28451-19fc-fee6-f28f-8679abf4be05@redhat.com>
On Wed, 04/19 18:38, Paolo Bonzini wrote:
>
>
> On 19/04/2017 11:17, Fam Zheng wrote:
> > Mirror calculates job len from current I/O progress:
> >
> > s->common.len = s->common.offset +
> > (cnt + s->sectors_in_flight) * BDRV_SECTOR_SIZE;
> >
> > The final "len" of a failed mirror job in iotests 109 depends on the
> > subtle timing of the completion of read and write issued in the first
> > mirror iteration. The second iteration may or may not have run when the
> > I/O error happens, resulting in non-deterministic output of the
> > BLOCK_JOB_COMPLETED event text.
> >
> > Similar to what was done in a752e4786, filter out the field to make the
> > test robust.
>
> There are more occurrences:
Yes. I'll convert them too..
Fam
next prev parent reply other threads:[~2017-04-20 0:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-19 9:17 [Qemu-devel] [PATCH v2] iotests: 109: Filter out "len" of failed jobs Fam Zheng
2017-04-19 16:38 ` Paolo Bonzini
2017-04-20 0:53 ` Fam Zheng [this message]
2017-04-19 17:13 ` Kevin Wolf
2017-04-20 0:53 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170420005322.GC25568@lemon.lan \
--to=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).