From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d10Ll-0003nD-Gk for qemu-devel@nongnu.org; Wed, 19 Apr 2017 20:53:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d10Lk-0003No-Mh for qemu-devel@nongnu.org; Wed, 19 Apr 2017 20:53:33 -0400 Date: Thu, 20 Apr 2017 08:53:22 +0800 From: Fam Zheng Message-ID: <20170420005322.GC25568@lemon.lan> References: <20170419091757.15507-1-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v2] iotests: 109: Filter out "len" of failed jobs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, Kevin Wolf , qemu-block@nongnu.org, Max Reitz On Wed, 04/19 18:38, Paolo Bonzini wrote: > > > On 19/04/2017 11:17, Fam Zheng wrote: > > Mirror calculates job len from current I/O progress: > > > > s->common.len = s->common.offset + > > (cnt + s->sectors_in_flight) * BDRV_SECTOR_SIZE; > > > > The final "len" of a failed mirror job in iotests 109 depends on the > > subtle timing of the completion of read and write issued in the first > > mirror iteration. The second iteration may or may not have run when the > > I/O error happens, resulting in non-deterministic output of the > > BLOCK_JOB_COMPLETED event text. > > > > Similar to what was done in a752e4786, filter out the field to make the > > test robust. > > There are more occurrences: Yes. I'll convert them too.. Fam