From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33552) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d18wS-0006id-NJ for qemu-devel@nongnu.org; Thu, 20 Apr 2017 06:04:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d18wR-0004Hv-Rq for qemu-devel@nongnu.org; Thu, 20 Apr 2017 06:04:00 -0400 Date: Thu, 20 Apr 2017 12:03:43 +0200 From: Kevin Wolf Message-ID: <20170420100343.GC4747@noname.redhat.com> References: <20170420075237.18219-1-famz@redhat.com> <149267590581.42.16656996221803790280@c05f1edc8ed1> <20170420083202.GF24486@lemon.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170420083202.GF24486@lemon.lan> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v13 00/20] block: Image locking series List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, mreitz@redhat.com Am 20.04.2017 um 10:32 hat Fam Zheng geschrieben: > > /var/tmp/patchew-tester-tmp-7vbaovju/src/block/file-posix.c: In funct= ion =E2=80=98raw_handle_lock_update=E2=80=99: > > /var/tmp/patchew-tester-tmp-7vbaovju/src/block/file-posix.c:1117:17: = error: =E2=80=98lock_fd=E2=80=99 may be used uninitialized in this functi= on [-Werror=3Dmaybe-uninitialized] > > qemu_close(lock_fd); > > ^~~~~~~~~~~~~~~~~~~ > > cc1: all warnings being treated as errors > > /var/tmp/patchew-tester-tmp-7vbaovju/src/rules.mak:69: recipe for tar= get 'block/file-posix.o' failed >=20 > False positive. lock_fd is initialized in a "if (op =3D=3D RAW_LT_PREPA= RE)" branch > above, and we are in a "case RAW_LT_PREPARE" switch branch too. Even if it's a false positive, obviously we still need to work around the build failure. Kevin