From: Jeff Cody <jcody@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, stefanha@redhat.com, kwolf@redhat.com,
jsnow@redhat.com, eblake@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 for-2.10 0/8] RBD reopen, read_only cleanup
Date: Thu, 20 Apr 2017 11:05:20 -0400 [thread overview]
Message-ID: <20170420150520.GI15762@localhost.localdomain> (raw)
In-Reply-To: <cover.1491597120.git.jcody@redhat.com>
On Fri, Apr 07, 2017 at 04:55:24PM -0400, Jeff Cody wrote:
>
> Changes from v1:
>
> Patch 2: Has v1 patch 8 (do not blindly xset bs->read_only) squashed into it
> (thanks Stefan)
> COW -> "copy-on-read" (Thanks John)
> Drop unneeded call in vvfat, and bypass enable_write_target (Stefan)
>
> Patch 5: Rename bdrv_try_... to bdrv_can_set_read_only() (Thanks John, Stefan)
>
> Patch 6: Use "reopen_state->flags" not "reopen_state->bs->open_flags"
> (Thanks John)
>
>
>
> This series does two things:
>
> 1.) Cleans up some of the logic behind setting the read_only flag
> for a BDS in the block layer, so that it is done consistently
> (and rules are applied consistently), and
>
> 2.) Adds .bdrv_reopen_prepare() implementation for RBD, so that block
> jobs can be run on backing chains that have rbd protocol nodes.
>
> Jeff Cody (8):
> block: add bdrv_set_read_only() helper function
> block: do not set BDS read_only if copy_on_read enabled
> block: honor BDRV_O_ALLOW_RDWR when clearing bs->read_only
> block: code movement
> block: introduce bdrv_can_set_read_only()
> block: use bdrv_can_set_read_only() during reopen
> block/rbd - update variable names to more apt names
> block/rbd: Add support for reopen()
>
> block.c | 56 +++++++++++++++++++++++++++++++++++---------
> block/bochs.c | 5 +++-
> block/cloop.c | 5 +++-
> block/dmg.c | 6 ++++-
> block/rbd.c | 65 +++++++++++++++++++++++++++++++++++++--------------
> block/vvfat.c | 19 +++++++++++----
> include/block/block.h | 2 ++
> 7 files changed, 123 insertions(+), 35 deletions(-)
>
> --
> 2.9.3
>
Thanks,
Applied to my block branch:
git://github.com/codyprime/qemu-kvm-jtc block
-Jeff
prev parent reply other threads:[~2017-04-20 15:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 20:55 [Qemu-devel] [PATCH v2 for-2.10 0/8] RBD reopen, read_only cleanup Jeff Cody
2017-04-07 20:55 ` [Qemu-devel] [PATCH v2 for-2.10 1/8] block: add bdrv_set_read_only() helper function Jeff Cody
2017-04-07 20:55 ` [Qemu-devel] [PATCH v2 for-2.10 2/8] block: do not set BDS read_only if copy_on_read enabled Jeff Cody
2017-04-07 20:55 ` [Qemu-devel] [PATCH v2 for-2.10 3/8] block: honor BDRV_O_ALLOW_RDWR when clearing bs->read_only Jeff Cody
2017-04-07 20:55 ` [Qemu-devel] [PATCH v2 for-2.10 4/8] block: code movement Jeff Cody
2017-04-07 20:55 ` [Qemu-devel] [PATCH v2 for-2.10 5/8] block: introduce bdrv_can_set_read_only() Jeff Cody
2017-04-07 20:55 ` [Qemu-devel] [PATCH v2 for-2.10 6/8] block: use bdrv_can_set_read_only() during reopen Jeff Cody
2017-04-07 20:55 ` [Qemu-devel] [PATCH v2 for-2.10 7/8] block/rbd - update variable names to more apt names Jeff Cody
2017-04-07 20:55 ` [Qemu-devel] [PATCH v2 for-2.10 8/8] block/rbd: Add support for reopen() Jeff Cody
2017-04-10 15:38 ` [Qemu-devel] [PATCH v2 for-2.10 0/8] RBD reopen, read_only cleanup Stefan Hajnoczi
2017-04-10 16:04 ` John Snow
2017-04-20 15:05 ` Jeff Cody [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170420150520.GI15762@localhost.localdomain \
--to=jcody@redhat.com \
--cc=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).