qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	Marcel Apfelbaum <marcel@redhat.com>,
	Igor Mammedov <imammedo@redhat.com>, Peter Xu <peterx@redhat.com>
Subject: [Qemu-devel] [PULL 12/15] hostmem: introduce host_memory_backend_mr_inited()
Date: Thu, 20 Apr 2017 15:47:02 -0300	[thread overview]
Message-ID: <20170420184705.25018-13-ehabkost@redhat.com> (raw)
In-Reply-To: <20170420184705.25018-1-ehabkost@redhat.com>

From: Peter Xu <peterx@redhat.com>

We were checking this against memory region size of host memory
backend's mr field to see whether the mr has been inited. This is
efficient but less elegant. Let's make a helper for it to avoid
confusions, along with some notes.

Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Xu <peterx@redhat.com>
Message-Id: <1489151370-15453-2-git-send-email-peterx@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 include/sysemu/hostmem.h | 1 +
 backends/hostmem.c       | 9 +++++++++
 2 files changed, 10 insertions(+)

diff --git a/include/sysemu/hostmem.h b/include/sysemu/hostmem.h
index ecae0cff19..ed6a437f4d 100644
--- a/include/sysemu/hostmem.h
+++ b/include/sysemu/hostmem.h
@@ -62,6 +62,7 @@ struct HostMemoryBackend {
     MemoryRegion mr;
 };
 
+bool host_memory_backend_mr_inited(HostMemoryBackend *backend);
 MemoryRegion *host_memory_backend_get_memory(HostMemoryBackend *backend,
                                              Error **errp);
 
diff --git a/backends/hostmem.c b/backends/hostmem.c
index 89feb9ed75..d8faab4bed 100644
--- a/backends/hostmem.c
+++ b/backends/hostmem.c
@@ -237,6 +237,15 @@ static void host_memory_backend_init(Object *obj)
     backend->prealloc = mem_prealloc;
 }
 
+bool host_memory_backend_mr_inited(HostMemoryBackend *backend)
+{
+    /*
+     * NOTE: We forbid zero-length memory backend, so here zero means
+     * "we haven't inited the backend memory region yet".
+     */
+    return memory_region_size(&backend->mr) != 0;
+}
+
 MemoryRegion *
 host_memory_backend_get_memory(HostMemoryBackend *backend, Error **errp)
 {
-- 
2.11.0.259.g40922b1

  parent reply	other threads:[~2017-04-20 18:48 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-20 18:46 [Qemu-devel] [PULL 00/15] Machine queue for 2.10 Eduardo Habkost
2017-04-20 18:46 ` [Qemu-devel] [PULL 01/15] memory: add section range info for IOMMU notifier Eduardo Habkost
2017-04-20 18:46 ` [Qemu-devel] [PULL 02/15] memory: provide IOMMU_NOTIFIER_FOREACH macro Eduardo Habkost
2017-04-20 18:46 ` [Qemu-devel] [PULL 03/15] memory: provide iommu_replay_all() Eduardo Habkost
2017-04-20 18:46 ` [Qemu-devel] [PULL 04/15] memory: introduce memory_region_notify_one() Eduardo Habkost
2017-04-20 18:46 ` [Qemu-devel] [PULL 05/15] memory: add MemoryRegionIOMMUOps.replay() callback Eduardo Habkost
2017-04-20 18:46 ` [Qemu-devel] [PULL 06/15] intel_iommu: use the correct memory region for device IOTLB notification Eduardo Habkost
2017-04-20 18:46 ` [Qemu-devel] [PULL 07/15] intel_iommu: provide its own replay() callback Eduardo Habkost
2017-04-20 18:46 ` [Qemu-devel] [PULL 08/15] intel_iommu: allow dynamic switch of IOMMU region Eduardo Habkost
2017-04-20 18:46 ` [Qemu-devel] [PULL 09/15] intel_iommu: enable remote IOTLB Eduardo Habkost
2017-04-20 18:47 ` [Qemu-devel] [PULL 10/15] qdev: Make "hotplugged" property read-only Eduardo Habkost
2017-04-20 18:47 ` [Qemu-devel] [PULL 11/15] hw/core/null-machine: Print error message when using the -kernel parameter Eduardo Habkost
2017-04-20 18:47 ` Eduardo Habkost [this message]
2017-04-20 18:47 ` [Qemu-devel] [PULL 13/15] hostmem: use host_memory_backend_mr_inited() where proper Eduardo Habkost
2017-04-20 18:47 ` [Qemu-devel] [PULL 14/15] qdev: Constify value passed to qdev_prop_set_macaddr Eduardo Habkost
2017-04-20 18:47 ` [Qemu-devel] [PULL 15/15] qdev: Constify local variable returned by blk_bs Eduardo Habkost
2017-04-21 10:41 ` [Qemu-devel] [PULL 00/15] Machine queue for 2.10 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170420184705.25018-13-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=marcel@redhat.com \
    --cc=mst@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).