From: Eduardo Habkost <ehabkost@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Marcel Apfelbaum <marcel@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
Krzysztof Kozlowski <krzk@kernel.org>
Subject: [Qemu-devel] [PULL 15/15] qdev: Constify local variable returned by blk_bs
Date: Thu, 20 Apr 2017 15:47:05 -0300 [thread overview]
Message-ID: <20170420184705.25018-16-ehabkost@redhat.com> (raw)
In-Reply-To: <20170420184705.25018-1-ehabkost@redhat.com>
From: Krzysztof Kozlowski <krzk@kernel.org>
Inside qdev_prop_set_drive() the value returned by blk_bs() is passed
only as pointer to const to bdrv_get_node_name() and pointed values is
not modified in other places so this can be made const for code
safeness.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Message-Id: <20170310200550.13313-3-krzk@kernel.org>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
hw/core/qdev-properties-system.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-system.c
index e885e650fb..79c2014135 100644
--- a/hw/core/qdev-properties-system.c
+++ b/hw/core/qdev-properties-system.c
@@ -409,7 +409,7 @@ void qdev_prop_set_drive(DeviceState *dev, const char *name,
if (value) {
ref = blk_name(value);
if (!*ref) {
- BlockDriverState *bs = blk_bs(value);
+ const BlockDriverState *bs = blk_bs(value);
if (bs) {
ref = bdrv_get_node_name(bs);
}
--
2.11.0.259.g40922b1
next prev parent reply other threads:[~2017-04-20 18:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 18:46 [Qemu-devel] [PULL 00/15] Machine queue for 2.10 Eduardo Habkost
2017-04-20 18:46 ` [Qemu-devel] [PULL 01/15] memory: add section range info for IOMMU notifier Eduardo Habkost
2017-04-20 18:46 ` [Qemu-devel] [PULL 02/15] memory: provide IOMMU_NOTIFIER_FOREACH macro Eduardo Habkost
2017-04-20 18:46 ` [Qemu-devel] [PULL 03/15] memory: provide iommu_replay_all() Eduardo Habkost
2017-04-20 18:46 ` [Qemu-devel] [PULL 04/15] memory: introduce memory_region_notify_one() Eduardo Habkost
2017-04-20 18:46 ` [Qemu-devel] [PULL 05/15] memory: add MemoryRegionIOMMUOps.replay() callback Eduardo Habkost
2017-04-20 18:46 ` [Qemu-devel] [PULL 06/15] intel_iommu: use the correct memory region for device IOTLB notification Eduardo Habkost
2017-04-20 18:46 ` [Qemu-devel] [PULL 07/15] intel_iommu: provide its own replay() callback Eduardo Habkost
2017-04-20 18:46 ` [Qemu-devel] [PULL 08/15] intel_iommu: allow dynamic switch of IOMMU region Eduardo Habkost
2017-04-20 18:46 ` [Qemu-devel] [PULL 09/15] intel_iommu: enable remote IOTLB Eduardo Habkost
2017-04-20 18:47 ` [Qemu-devel] [PULL 10/15] qdev: Make "hotplugged" property read-only Eduardo Habkost
2017-04-20 18:47 ` [Qemu-devel] [PULL 11/15] hw/core/null-machine: Print error message when using the -kernel parameter Eduardo Habkost
2017-04-20 18:47 ` [Qemu-devel] [PULL 12/15] hostmem: introduce host_memory_backend_mr_inited() Eduardo Habkost
2017-04-20 18:47 ` [Qemu-devel] [PULL 13/15] hostmem: use host_memory_backend_mr_inited() where proper Eduardo Habkost
2017-04-20 18:47 ` [Qemu-devel] [PULL 14/15] qdev: Constify value passed to qdev_prop_set_macaddr Eduardo Habkost
2017-04-20 18:47 ` Eduardo Habkost [this message]
2017-04-21 10:41 ` [Qemu-devel] [PULL 00/15] Machine queue for 2.10 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170420184705.25018-16-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=krzk@kernel.org \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).