Re: [Qemu-devel] [PATCH 06/14] crypto: Make errp the last parameter of functions

["Daniel P. Berrange" <berrange@redhat.com>]

On Mon, Apr 24, 2017 at 11:24:31AM +0200, Markus Armbruster wrote:
> Fam Zheng <famz@redhat.com> writes:
> 
> > On Mon, 04/24 09:28, Daniel P. Berrange wrote:
> >> On Fri, Apr 21, 2017 at 08:27:02PM +0800, Fam Zheng wrote:
> >> > Move opaque to 2nd instead of the 2nd to last, so that compilers help
> >> > check with the convertion.
> >> 
> >> Moving 'opaque' like this should not be done.
> >> 
> >> If you want the compiler to check the fixes, it should be done in
> >> just two stages. First move errp & move opaque to start, compile
> >> it & verify. Then put opaque back to where it was, and compile
> >> again. The resulting commit thus only has the errp move, not the
> >> unrelated & uneccessary opaque move.
> >
> > The idea is to let everyone's compiler verifies this patch, and also to avoid
> > possible bugs introduced in backporting/rebasing/merging - for example if a
> > patch in another tree addes one more implementation that uses the old order, we
> > can notice.

That is true in general, but in reality this particular function is not
widely used and so chance of there being another out of tree impl is
essentially zero.

> >
> > If you don't like this, we can be careful and don't move opaque; or after a
> > short while, move opaque back in a separate commit (since Markus already sent a
> > pull request).
> 
> I'm prepared to NAK my pull request if we think we need more time to
> discuss the patches.

It isn't a big deal either way. I can just send a follow up patch if needed

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|