From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57294) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d2aYb-0001vu-Ak for qemu-devel@nongnu.org; Mon, 24 Apr 2017 05:45:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d2aYa-0005vP-AN for qemu-devel@nongnu.org; Mon, 24 Apr 2017 05:45:21 -0400 Date: Mon, 24 Apr 2017 17:45:12 +0800 From: Fam Zheng Message-ID: <20170424094512.GC14416@lemon.lan> References: <20170424091659.26708-1-berrange@redhat.com> <20170424091659.26708-4-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170424091659.26708-4-berrange@redhat.com> Subject: Re: [Qemu-devel] [PATCH v5 3/4] qemu-img: introduce --target-image-opts for 'convert' command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Eric Blake , Max Reitz , Kevin Wolf On Mon, 04/24 10:16, Daniel P. Berrange wrote: > The '--image-opts' flags indicates whether the source filename s/flags/flag/ or s/indicates/indicate/, I think? > includes options. The target filename has to remain in the > plain filename format though, since it needs to be passed to > bdrv_create(). When using --skip-create though, it would be > possible to use image-opts syntax. This adds --target-image-opts > to indicate that the target filename includes options. Currently > this mandates use of the --skip-create flag too. Fam