From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54001) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d2sWz-00036F-6B for qemu-devel@nongnu.org; Tue, 25 Apr 2017 00:56:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d2sWu-0004Rc-Ao for qemu-devel@nongnu.org; Tue, 25 Apr 2017 00:56:53 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:41511 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d2sWu-0004QS-4Z for qemu-devel@nongnu.org; Tue, 25 Apr 2017 00:56:48 -0400 Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v3P4raZt120886 for ; Tue, 25 Apr 2017 00:56:47 -0400 Received: from e17.ny.us.ibm.com (e17.ny.us.ibm.com [129.33.205.207]) by mx0a-001b2d01.pphosted.com with ESMTP id 2a1nx6qsbs-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 25 Apr 2017 00:56:46 -0400 Received: from localhost by e17.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 25 Apr 2017 00:56:46 -0400 Date: Tue, 25 Apr 2017 12:56:42 +0800 From: Dong Jia Shi References: <20170425045201.71457-1-bjsdjshi@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170425045201.71457-1-bjsdjshi@linux.vnet.ibm.com> Message-Id: <20170425045642.GG31848@bjsdjshi@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH RFC 1/1] vfio/pci: Fix incorrect error message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dong Jia Shi Cc: qemu-devel@nongnu.org, alex.williamson@redhat.com * Dong Jia Shi [2017-04-25 06:52:01 +0200]: Hey Alex, Please ignore the "RFC" tag in the subject. Sorry for the mistake. > When the "No host device provided" error occurs, the hint message > that starts with "Use -vfio-pci," makes no sense, since "-vfio-pci" > is not a valid command line parameter. > > Correct this by replacing "-vfio-pci" with "-device vfio-pci". > > Signed-off-by: Dong Jia Shi > --- > hw/vfio/pci.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c > index 03a3d01..32aca77 100644 > --- a/hw/vfio/pci.c > +++ b/hw/vfio/pci.c > @@ -2625,8 +2625,8 @@ static void vfio_realize(PCIDevice *pdev, Error **errp) > if (!(~vdev->host.domain || ~vdev->host.bus || > ~vdev->host.slot || ~vdev->host.function)) { > error_setg(errp, "No provided host device"); > - error_append_hint(errp, "Use -vfio-pci,host=DDDD:BB:DD.F " > - "or -vfio-pci,sysfsdev=PATH_TO_DEVICE\n"); > + error_append_hint(errp, "Use -device vfio-pci,host=DDDD:BB:DD.F " > + "or -device vfio-pci,sysfsdev=PATH_TO_DEVICE\n"); > return; > } > vdev->vbasedev.sysfsdev = > -- > 2.10.2 > -- Dong Jia Shi