qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: dgilbert@redhat.com, lvivier@redhat.com, peterx@redhat.com
Subject: [Qemu-devel] [PATCH 12/26] audio: Remove Unused OPL_TYPE_*
Date: Wed, 26 Apr 2017 00:37:25 +0200	[thread overview]
Message-ID: <20170425223739.6703-13-quintela@redhat.com> (raw)
In-Reply-To: <20170425223739.6703-1-quintela@redhat.com>

Since we removed the previous unused devices, they are not used anymore.

Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 hw/audio/fmopl.c | 16 ----------------
 hw/audio/fmopl.h |  3 ---
 2 files changed, 19 deletions(-)

diff --git a/hw/audio/fmopl.c b/hw/audio/fmopl.c
index b1cb4b4..9171001 100644
--- a/hw/audio/fmopl.c
+++ b/hw/audio/fmopl.c
@@ -1188,28 +1188,12 @@ unsigned char OPLRead(FM_OPL *OPL,int a)
 	switch(OPL->address)
 	{
 	case 0x05: /* KeyBoard IN */
-		if(OPL->type&OPL_TYPE_KEYBOARD)
-		{
-			if(OPL->keyboardhandler_r)
-				return OPL->keyboardhandler_r(OPL->keyboard_param);
-			else {
-				LOG(LOG_WAR,("OPL:read unmapped KEYBOARD port\n"));
-			}
-		}
 		return 0;
 #if 0
 	case 0x0f: /* ADPCM-DATA  */
 		return 0;
 #endif
 	case 0x19: /* I/O DATA    */
-		if(OPL->type&OPL_TYPE_IO)
-		{
-			if(OPL->porthandler_r)
-				return OPL->porthandler_r(OPL->port_param);
-			else {
-				LOG(LOG_WAR,("OPL:read unmapped I/O port\n"));
-			}
-		}
 		return 0;
 	case 0x1a: /* PCM-DATA    */
 		return 0;
diff --git a/hw/audio/fmopl.h b/hw/audio/fmopl.h
index c236287..8ef0b3e 100644
--- a/hw/audio/fmopl.h
+++ b/hw/audio/fmopl.h
@@ -12,9 +12,6 @@ typedef unsigned char (*OPL_PORTHANDLER_R)(int param);
 /* !!!!! here is private section , do not access there member direct !!!!! */
 
 #define OPL_TYPE_WAVESEL   0x01  /* waveform select    */
-#define OPL_TYPE_ADPCM     0x02  /* DELTA-T ADPCM unit */
-#define OPL_TYPE_KEYBOARD  0x04  /* keyboard interface */
-#define OPL_TYPE_IO        0x08  /* I/O port */
 
 /* Saving is necessary for member of the 'R' mark for suspend/resume */
 /* ---------- OPL one of slot  ---------- */
-- 
2.9.3

  parent reply	other threads:[~2017-04-25 22:38 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-25 22:37 [Qemu-devel] [PATCH 00/26] Audio Cleanup Juan Quintela
2017-04-25 22:37 ` [Qemu-devel] [PATCH 01/26] adlib: Remove support for YMF262 Juan Quintela
2017-04-25 22:37 ` [Qemu-devel] [PATCH 02/26] audio: remove Y8950 configuration Juan Quintela
2017-04-25 22:37 ` [Qemu-devel] [PATCH 03/26] audio: Remove YM3526 support Juan Quintela
2017-04-25 22:37 ` [Qemu-devel] [PATCH 04/26] audio: YM3812 was always defined Juan Quintela
2017-04-25 22:37 ` [Qemu-devel] [PATCH 05/26] audio: Remove UINT8 Juan Quintela
2017-04-26  1:41   ` Philippe Mathieu-Daudé
2017-04-26  7:22     ` Juan Quintela
2017-04-25 22:37 ` [Qemu-devel] [PATCH 06/26] audio: remove UINT16 Juan Quintela
2017-04-25 22:37 ` [Qemu-devel] [PATCH 07/26] audio: remove UINT32 Juan Quintela
2017-04-25 22:37 ` [Qemu-devel] [PATCH 08/26] audio: Remove INT8 Juan Quintela
2017-04-25 22:37 ` [Qemu-devel] [PATCH 09/26] audio: remove INT16 Juan Quintela
2017-04-25 22:37 ` [Qemu-devel] [PATCH 10/26] audio: Remove INT32 Juan Quintela
2017-04-26  1:43   ` Philippe Mathieu-Daudé
2017-04-26  7:23     ` Juan Quintela
2017-04-25 22:37 ` [Qemu-devel] [PATCH 11/26] audio: Unfold OPLSAMPLE Juan Quintela
2017-04-25 22:37 ` Juan Quintela [this message]
2017-04-25 22:37 ` [Qemu-devel] [PATCH 13/26] audio: Remove type field Juan Quintela
2017-04-25 22:37 ` [Qemu-devel] [PATCH 14/26] audio: Remove unused fields Juan Quintela
2017-04-25 22:37 ` [Qemu-devel] [PATCH 15/26] audio: GUSbyte is uint8_t Juan Quintela
2017-04-25 22:37 ` [Qemu-devel] [PATCH 16/26] audio: remove GUSchar Juan Quintela
2017-04-25 22:37 ` [Qemu-devel] [PATCH 17/26] audio: GUSword is uint16_t Juan Quintela
2017-04-25 22:37 ` [Qemu-devel] [PATCH 18/26] " Juan Quintela
2017-04-25 22:37 ` [Qemu-devel] [PATCH 19/26] audio: GUSsample is int16_t Juan Quintela
2017-04-26  1:47   ` Philippe Mathieu-Daudé
2017-04-25 22:37 ` [Qemu-devel] [PATCH 20/26] audio: OPLSetIRQHandler is not used anywhere Juan Quintela
2017-04-25 22:37 ` [Qemu-devel] [PATCH 21/26] audio: OPLSetUpdateHandler " Juan Quintela
2017-04-25 22:37 ` [Qemu-devel] [PATCH 22/26] audio: IRQHandler is not used anymore Juan Quintela
2017-04-25 22:37 ` [Qemu-devel] [PATCH 23/26] audio: UpdateHandler " Juan Quintela
2017-04-25 22:37 ` [Qemu-devel] [PATCH 24/26] audio: Remove unused typedefs Juan Quintela
2017-04-25 22:37 ` [Qemu-devel] [PATCH 25/26] audio: un-export OPLResetChip Juan Quintela
2017-04-26  1:48   ` Philippe Mathieu-Daudé
2017-04-25 22:37 ` [Qemu-devel] [PATCH 26/26] audio: Use ARRAY_SIZE from qemu/osdep.h Juan Quintela
2017-04-26  1:48   ` Philippe Mathieu-Daudé
2017-04-25 23:31 ` [Qemu-devel] [PATCH 00/26] Audio Cleanup no-reply
2017-04-26  7:20 ` Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170425223739.6703-13-quintela@redhat.com \
    --to=quintela@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).