From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48819) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d3I9Z-0004Ar-UK for qemu-devel@nongnu.org; Wed, 26 Apr 2017 04:18:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d3I9W-0000q5-Ni for qemu-devel@nongnu.org; Wed, 26 Apr 2017 04:18:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42738) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d3I9W-0000pW-Gv for qemu-devel@nongnu.org; Wed, 26 Apr 2017 04:18:22 -0400 Date: Wed, 26 Apr 2017 09:18:17 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20170426081816.GA2098@work-vm> References: <1493179907-22516-1-git-send-email-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1493179907-22516-1-git-send-email-thuth@redhat.com> Subject: Re: [Qemu-devel] [PATCH] monitor: Check whether TCG is enabled before running the "info jit" code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: qemu-devel@nongnu.org, Markus Armbruster , Peter Maydell * Thomas Huth (thuth@redhat.com) wrote: > The "info jit" command currently aborts on Mac OS X with the message > "qemu_mutex_lock: Invalid argument" when running with "-M accel=qtest". > We should only call into the TCG code here if TCG has really been > enabled and initialized. > > Signed-off-by: Thomas Huth > --- > monitor.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/monitor.c b/monitor.c > index be282ec..3e0979d 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -1086,6 +1086,11 @@ static void hmp_info_registers(Monitor *mon, const QDict *qdict) > > static void hmp_info_jit(Monitor *mon, const QDict *qdict) > { > + if (!tcg_enabled()) { > + error_report("JIT information is only available with accel=tcg"); > + return; > + } > + > dump_exec_info((FILE *)mon, monitor_fprintf); > dump_drift_info((FILE *)mon, monitor_fprintf); > } so tcg_enabled checks tcg_ctx.code_gen_buffer != NULL code_gen_buffer is set by code_gen_alloc code_gen_alloc does a qemu_mutex_init of tb_lock and the previous problem was an uninitialised tb_lock. So: Reviewed-by: Dr. David Alan Gilbert Peter: Does this fix the hmp test for you? Dave > -- > 1.8.3.1 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK