From: Peter Xu <peterx@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] ramblock: add new hmp command "info ramblock"
Date: Thu, 27 Apr 2017 10:09:31 +0800 [thread overview]
Message-ID: <20170427020931.GD26792@pxdev.xzpeter.org> (raw)
In-Reply-To: <8760hrxtcn.fsf@dusky.pond.sub.org>
On Wed, Apr 26, 2017 at 02:10:16PM +0200, Markus Armbruster wrote:
> Peter Xu <peterx@redhat.com> writes:
>
> > To dump information about ramblocks. It looks like:
> >
> > (qemu) info ramblock
> > Block Name PSize Offset Used Total
> > /objects/mem 2M 0x0000000000000000 0x0000000080000000 0x0000000080000000
> > vga.vram 4K 0x0000000080060000 0x0000000001000000 0x0000000001000000
> > /rom@etc/acpi/tables 4K 0x00000000810b0000 0x0000000000020000 0x0000000000200000
> > pc.bios 4K 0x0000000080000000 0x0000000000040000 0x0000000000040000
> > 0000:00:03.0/e1000.rom 4K 0x0000000081070000 0x0000000000040000 0x0000000000040000
> > pc.rom 4K 0x0000000080040000 0x0000000000020000 0x0000000000020000
> > 0000:00:02.0/vga.rom 4K 0x0000000081060000 0x0000000000010000 0x0000000000010000
> > /rom@etc/table-loader 4K 0x00000000812b0000 0x0000000000001000 0x0000000000001000
> > /rom@etc/acpi/rsdp 4K 0x00000000812b1000 0x0000000000001000 0x0000000000001000
> >
> > Signed-off-by: Peter Xu <peterx@redhat.com>
>
> You implemented this just for HMP.
>
> In general, functionality available in HMP should also available in QMP.
> Exceptions include functionality that makes no sense in QMP, or is of
> use only for human users. If you think your command is an exception,
> please explain why in the commit message.
>
> If it isn't, you need to implement it for QMP, then rewrite the HMP
> version to reuse either the QMP command or a common core.
I see. I think it should belongs to the first condition, which should
only be used by human users, especially developers. Maybe I can repost
with some more comment in the commit message to emphasize that.
But, before that, I would also want to know whether anyone would think
this an useful thing even to QMP... If so, I would be glad to provide
QMP interface as well.
Thanks,
--
Peter Xu
next prev parent reply other threads:[~2017-04-27 2:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 7:44 [Qemu-devel] [PATCH 0/2] ramblock: add hmp command "info ramblock" Peter Xu
2017-04-26 7:44 ` [Qemu-devel] [PATCH 1/2] ramblock: add RAMBLOCK_FOREACH() Peter Xu
2017-04-26 7:44 ` [Qemu-devel] [PATCH 2/2] ramblock: add new hmp command "info ramblock" Peter Xu
2017-04-26 12:10 ` Markus Armbruster
2017-04-27 2:09 ` Peter Xu [this message]
2017-04-27 7:07 ` Markus Armbruster
2017-04-27 7:39 ` Paolo Bonzini
2017-04-27 7:57 ` Markus Armbruster
2017-04-27 8:06 ` Peter Xu
2017-04-26 10:21 ` [Qemu-devel] [PATCH 0/2] ramblock: add " no-reply
2017-04-26 10:32 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170427020931.GD26792@pxdev.xzpeter.org \
--to=peterx@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).