Re: [Qemu-devel] [PATCH 10/41] migration: Move postcopy-ram.h to migration/

["Dr. David Alan Gilbert" <dgilbert@redhat.com>]

* Juan Quintela (quintela@redhat.com) wrote:
> It is internal to migration, not intended for other users.
> 
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  migration/migration.c                           | 2 +-
>  migration/postcopy-ram.c                        | 2 +-
>  {include/migration => migration}/postcopy-ram.h | 0
>  migration/ram.c                                 | 2 +-
>  migration/savevm.c                              | 2 +-
>  5 files changed, 4 insertions(+), 4 deletions(-)
>  rename {include/migration => migration}/postcopy-ram.h (100%)
> 
> diff --git a/migration/migration.c b/migration/migration.c
> index fe30227..fef1f0a 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -28,7 +28,7 @@
>  #include "qemu/sockets.h"
>  #include "qemu/rcu.h"
>  #include "migration/block.h"
> -#include "migration/postcopy-ram.h"
> +#include "postcopy-ram.h"

Do we need to do all those #include changes, it's still migration/postcopy-ram.h,
it seems to work for me without changing the includes.

Dave

>  #include "qemu/thread.h"
>  #include "qmp-commands.h"
>  #include "trace.h"
> diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c
> index e3f4a37..cdadaf6 100644
> --- a/migration/postcopy-ram.c
> +++ b/migration/postcopy-ram.c
> @@ -20,7 +20,7 @@
>  
>  #include "qemu-common.h"
>  #include "migration/migration.h"
> -#include "migration/postcopy-ram.h"
> +#include "postcopy-ram.h"
>  #include "sysemu/sysemu.h"
>  #include "sysemu/balloon.h"
>  #include "qemu/error-report.h"
> diff --git a/include/migration/postcopy-ram.h b/migration/postcopy-ram.h
> similarity index 100%
> rename from include/migration/postcopy-ram.h
> rename to migration/postcopy-ram.h
> diff --git a/migration/ram.c b/migration/ram.c
> index 47e66f4..5fcf593 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -37,7 +37,7 @@
>  #include "qemu/main-loop.h"
>  #include "xbzrle.h"
>  #include "migration/migration.h"
> -#include "migration/postcopy-ram.h"
> +#include "postcopy-ram.h"
>  #include "exec/address-spaces.h"
>  #include "migration/page_cache.h"
>  #include "qemu/error-report.h"
> diff --git a/migration/savevm.c b/migration/savevm.c
> index 7a07ea6..1b2a83c 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -37,7 +37,7 @@
>  #include "qemu/timer.h"
>  #include "migration/migration.h"
>  #include "qemu-file-channel.h"
> -#include "migration/postcopy-ram.h"
> +#include "postcopy-ram.h"
>  #include "qapi/qmp/qerror.h"
>  #include "qemu/error-report.h"
>  #include "qemu/queue.h"
> -- 
> 2.9.3
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK