From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54983) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d3iFE-0003vQ-Ay for qemu-devel@nongnu.org; Thu, 27 Apr 2017 08:10:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d3iFB-0006Bi-4J for qemu-devel@nongnu.org; Thu, 27 Apr 2017 08:10:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45488) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d3iFA-0006Av-Rq for qemu-devel@nongnu.org; Thu, 27 Apr 2017 08:09:57 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E6DAAC056792 for ; Thu, 27 Apr 2017 12:09:55 +0000 (UTC) Date: Thu, 27 Apr 2017 13:09:49 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20170427120949.GH2082@work-vm> References: <20170425220451.6028-1-quintela@redhat.com> <20170425220451.6028-11-quintela@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170425220451.6028-11-quintela@redhat.com> Subject: Re: [Qemu-devel] [PATCH 10/41] migration: Move postcopy-ram.h to migration/ List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org, lvivier@redhat.com, peterx@redhat.com * Juan Quintela (quintela@redhat.com) wrote: > It is internal to migration, not intended for other users. > > Signed-off-by: Juan Quintela > --- > migration/migration.c | 2 +- > migration/postcopy-ram.c | 2 +- > {include/migration => migration}/postcopy-ram.h | 0 > migration/ram.c | 2 +- > migration/savevm.c | 2 +- > 5 files changed, 4 insertions(+), 4 deletions(-) > rename {include/migration => migration}/postcopy-ram.h (100%) > > diff --git a/migration/migration.c b/migration/migration.c > index fe30227..fef1f0a 100644 > --- a/migration/migration.c > +++ b/migration/migration.c > @@ -28,7 +28,7 @@ > #include "qemu/sockets.h" > #include "qemu/rcu.h" > #include "migration/block.h" > -#include "migration/postcopy-ram.h" > +#include "postcopy-ram.h" Do we need to do all those #include changes, it's still migration/postcopy-ram.h, it seems to work for me without changing the includes. Dave > #include "qemu/thread.h" > #include "qmp-commands.h" > #include "trace.h" > diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c > index e3f4a37..cdadaf6 100644 > --- a/migration/postcopy-ram.c > +++ b/migration/postcopy-ram.c > @@ -20,7 +20,7 @@ > > #include "qemu-common.h" > #include "migration/migration.h" > -#include "migration/postcopy-ram.h" > +#include "postcopy-ram.h" > #include "sysemu/sysemu.h" > #include "sysemu/balloon.h" > #include "qemu/error-report.h" > diff --git a/include/migration/postcopy-ram.h b/migration/postcopy-ram.h > similarity index 100% > rename from include/migration/postcopy-ram.h > rename to migration/postcopy-ram.h > diff --git a/migration/ram.c b/migration/ram.c > index 47e66f4..5fcf593 100644 > --- a/migration/ram.c > +++ b/migration/ram.c > @@ -37,7 +37,7 @@ > #include "qemu/main-loop.h" > #include "xbzrle.h" > #include "migration/migration.h" > -#include "migration/postcopy-ram.h" > +#include "postcopy-ram.h" > #include "exec/address-spaces.h" > #include "migration/page_cache.h" > #include "qemu/error-report.h" > diff --git a/migration/savevm.c b/migration/savevm.c > index 7a07ea6..1b2a83c 100644 > --- a/migration/savevm.c > +++ b/migration/savevm.c > @@ -37,7 +37,7 @@ > #include "qemu/timer.h" > #include "migration/migration.h" > #include "qemu-file-channel.h" > -#include "migration/postcopy-ram.h" > +#include "postcopy-ram.h" > #include "qapi/qmp/qerror.h" > #include "qemu/error-report.h" > #include "qemu/queue.h" > -- > 2.9.3 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK