From: Kevin Wolf <kwolf@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: qemu-devel@nongnu.org, Fam Zheng <famz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 1/1] block: fix alignment calculations in bdrv_co_do_zero_pwritev
Date: Thu, 27 Apr 2017 16:44:36 +0200 [thread overview]
Message-ID: <20170427144436.GH4805@noname.str.redhat.com> (raw)
In-Reply-To: <1493196046-5607-1-git-send-email-den@openvz.org>
Am 26.04.2017 um 10:40 hat Denis V. Lunev geschrieben:
> tail_padding_bytes is calculated wrong. F.e. for
> offset = 0
> bytes = 2048
> align = 512
> we will have tail_padding_bytes = 512 which is definitely wrong. The patch
> fixes that arithmetics.
>
> Fortunately this problem is harmless, we will have 1 extra allocation and
> free thus there is no need to put this into stable. The problem is here
> from the very beginning.
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Stefan Hajnoczi <stefanha@redhat.com>
> CC: Fam Zheng <famz@redhat.com>
Thanks, applied to block-next.
Kevin
prev parent reply other threads:[~2017-04-27 14:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 8:40 [Qemu-devel] [PATCH 1/1] block: fix alignment calculations in bdrv_co_do_zero_pwritev Denis V. Lunev
2017-04-26 13:21 ` Eric Blake
2017-04-27 14:44 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170427144436.GH4805@noname.str.redhat.com \
--to=kwolf@redhat.com \
--cc=den@openvz.org \
--cc=famz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).