[Qemu-devel] [PATCH] tests: Ignore another built executable

[Qemu-devel] [PATCH] tests: Ignore another built executable

[Eric Blake]

Commit 78f86a2b7 added a new test, but forgot to exclude the built
binary from version control.

Signed-off-by: Eric Blake <eblake@redhat.com>
---
 tests/.gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/.gitignore b/tests/.gitignore
index 5ab00a9..40c2e3e 100644
--- a/tests/.gitignore
+++ b/tests/.gitignore
@@ -40,6 +40,7 @@ test-crypto-tlssession-server/
 test-crypto-xts
 test-cutils
 test-hbitmap
+test-hmp
 test-int128
 test-iov
 test-io-channel-buffer
-- 
2.9.3

Re: [Qemu-devel] [PATCH] tests: Ignore another built executable

[Thomas Huth]

On 28.04.2017 04:23, Eric Blake wrote:
> Commit 78f86a2b7 added a new test, but forgot to exclude the built
> binary from version control.
> 
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
>  tests/.gitignore | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/.gitignore b/tests/.gitignore
> index 5ab00a9..40c2e3e 100644
> --- a/tests/.gitignore
> +++ b/tests/.gitignore
> @@ -40,6 +40,7 @@ test-crypto-tlssession-server/
>  test-crypto-xts
>  test-cutils
>  test-hbitmap
> +test-hmp
>  test-int128
>  test-iov
>  test-io-channel-buffer

Ah, ok, I'm only doing out-of-tree builds, that's why I did not notice
this...

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [Qemu-devel] [PATCH] tests: Ignore another built executable

[Daniel P. Berrange]

On Thu, Apr 27, 2017 at 09:23:29PM -0500, Eric Blake wrote:
> Commit 78f86a2b7 added a new test, but forgot to exclude the built
> binary from version control.

CC Fam

I wonder if the patchew test system could be made to report an error
if git identifies built files that are not ignored.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [Qemu-devel] [PATCH] tests: Ignore another built executable

[Michael Tokarev]

28.04.2017 05:23, Eric Blake wrote:
> Commit 78f86a2b7 added a new test, but forgot to exclude the built
> binary from version control.

Applied to -trivial (adding mention of test-hmp to subject), thanks!

/mjt

Re: [Qemu-devel] [PATCH] tests: Ignore another built executable

[Fam Zheng]

On Fri, 04/28 09:54, Daniel P. Berrange wrote:
> On Thu, Apr 27, 2017 at 09:23:29PM -0500, Eric Blake wrote:
> > Commit 78f86a2b7 added a new test, but forgot to exclude the built
> > binary from version control.
> 
> CC Fam
> 
> I wonder if the patchew test system could be made to report an error
> if git identifies built files that are not ignored.
> 

If we had .git in the docker tests that patchew uses, it would be easy.  That's
an unfortunate dependency for a number of other features, I'll see what I can
do.

Fam